Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Tools: event tests #655

Open
wants to merge 9 commits into
base: master
from

Conversation

@rustyrussell
Copy link
Collaborator

commented Aug 5, 2019

Hi all, this is the framework I've been using to test various event scenarios. So far it has found two significant issues in our implementation.

It has some simple coverage of the existing HTLC flow, and also covers option_static_remotekey.

TODO:

  • Driver implementation for c-lightning.
  • Driver implementations for lnd/Eclair
  • Simple BOLT 1 tests
  • Basic HTLC add/fail/fulfill tests
  • Feerate tests
  • Routing tests
  • Gossip tests
  • #557 tests
  • Unilataral close tests.

My next priority is to implement #557 since that has the most urgent need.

rustyrussell added some commits Aug 5, 2019

tests: spec for test vectors, and a simple example.
I initially used JSON, but it was not human-writable.  The simple
DSL is much more human-writable, and readable.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests: c-lightning support.
Works with current c-lightning master branch, as long as it's built with
--enable-developer.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests: add reconnection tests to add-htlc.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests/events: test unknown messages.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests/events: split htlc-add and htlc-fail tests.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests: channel opening test.
Very simple successful open.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests: HTLC-adding test.
Does a simple dust HTLC and a non-dust HTLC.  Both fail.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests: htlc success tests.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
tests: make to_self_delay different between peers.
This helps for testing that we handle it correctly.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.