Fixing badges in README #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Markdown for badges in the README has newlines incorrectly separating the images from the associated URL link, causing the link URLs to show up as text. This removes the newlines so that the badges render properly.
trevinhofmann
approved these changes
Mar 22, 2017
| * [Contribution guide](https://github.com/lightningnetwork/lnd/blob/master/docs/code_contribution_guidelines.md) |
There was a problem hiding this comment.
Hmm, yeah not sure what happened here. Visually, there's no diff at all created by this line.
Roasbeef
approved these changes
Mar 22, 2017
There was a problem hiding this comment.
Excellent! I'd noticed that the formatting starting being rendered incorrectly recently. My guess is that when Github published their formal spec to their flavor of markdown, they modified their parser to comply with the new spec.
Thanks for the review @thofmann! LGTM 🌟
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Markdown for badges in the README has newlines incorrectly separating the
images from the associated URL link, causing the link URLs to show up as text.
This removes the newlines so that the badges render properly.