Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build+docs: bump to golang 1.11 #1786

Merged
merged 4 commits into from
Oct 8, 2018
Merged

build+docs: bump to golang 1.11 #1786

merged 4 commits into from
Oct 8, 2018

Conversation

Roasbeef
Copy link
Member

This was referenced Aug 25, 2018
Closed
Closed
@Roasbeef Roasbeef added golang/build system Related to the go language and compiler P3 might get fixed, nice to have needs testing PR hasn't yet been actively tested on testnet/mainnet labels Sep 14, 2018
@halseth halseth mentioned this pull request Sep 17, 2018
Merged
@halseth halseth added this to the 0.6 milestone Sep 19, 2018
@Roasbeef Roasbeef force-pushed the golang-1.1 branch 4 times, most recently from 924851a to 142d104 Compare October 7, 2018 05:24
@Roasbeef
multi: update to go 1.11 gofmt
d8e6085
@Roasbeef
build: update build file to exclude go 1.10 from linting
8bc6169 
In this commit, we modify our build file to only lint under go 1.11. We
do this as there's been a breaking change in gofmt between go 1.10 and
go 1.11 that causes files which pass the linter under go 1.10, to fail
the linter under go 1.11. In the end, we only really need to lint using
one version of go.

In order to achieve this, we "unroll" the build matrix to enumerate each
version and the environment variables that it should be run with. We
then modify the Makefile to only include the lint directive if the
particular env variable is set ($(USE_LINT)). With these two changes,
we'll now only lint under go 1.11.
@Roasbeef
htlcswitch: fix lint under go 1.11
f07260a
cfromknecht
cfromknecht approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@cfromknecht cfromknecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Roasbeef Roasbeef self-assigned this Oct 8, 2018
@Roasbeef Roasbeef merged commit 3fda102 into lightningnetwork:master Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfromknecht cfromknecht cfromknecht approved these changes

Assignees

@Roasbeef Roasbeef

Labels
golang/build system Related to the go language and compiler needs testing PR hasn't yet been actively tested on testnet/mainnet P3 might get fixed, nice to have
Projects
None yet
Milestone
0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@Roasbeef @cfromknecht @halseth