rpc: prevent spending unconfirmed funds within OpenChannel by default #2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halseth
reviewed
Oct 17, 2018
rpcserver.go
Outdated
| @@ -761,6 +761,22 @@ func (r *rpcServer) OpenChannel(in *lnrpc.OpenChannelRequest, | |||
| "non-negative number") | |||
| } | |||
|
|
|||
| var minConfs int32 | |||
There was a problem hiding this comment.
Doesn't look like it is ever set in the case in.MinConfs > 0
wpaulino
force-pushed
the
openchannel-unconfirmed-funds
branch
from
0736808
to
cd802a6
Compare
halseth
reviewed
Oct 18, 2018
Roasbeef
added
rpc
In this commit, we address a slight regression in the defaults provided by the OpenChannel RPC with regards to spending unconfirmed outputs to fund funding transactions. We now add a new boolean parameter to OpenChannelRequest: SpendUnconfirmed. If set, we'll use this to indicate to the server that the funding transaction of the channel to be created can spend the wallet's unconfirmed outputs to fund it. This addition is needed because otherwise, if the caller doesn't specify a MinConfs parameter to the request, then a default of 0 will be used, which is not ideal.
wpaulino
force-pushed
the
openchannel-unconfirmed-funds
branch
from
cd802a6
to
16b5f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we address a slight regression in the defaults provided
by the OpenChannel RPC with regards to spending unconfirmed outputs to
fund funding transactions. We now add a new boolean parameter to
OpenChannelRequest: SpendUnconfirmed. If set, we'll use this to
indicate to the server that the funding transaction of the channel to be
created can spend the wallet's unconfirmed outputs to fund it. This
addition is needed because otherwise, if the caller doesn't specify a
MinConfs parameter to the request, then a default of 0 will be used,
which is not ideal.