Add litecoin docker image and container. #209

andrewshvv · 2017-05-13T20:46:02Z

No description provided.

mention-bot · 2017-05-13T20:46:03Z

@AndrewSamokhvalov, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Roasbeef, @murtyjones and @f-a-a to be potential reviewers.

coveralls · 2017-05-13T20:53:25Z

Coverage decreased (-0.01%) to 73.532% when pulling 7b99e6a937440c1de498a9b313170e1d1f5349c1 on AndrewSamokhvalov:litecoin_docker into 1124b45 on lightningnetwork:master.

coveralls · 2017-05-13T22:30:01Z

Coverage remained the same at 73.542% when pulling 9454bc69991751c28c0d5352e1e23138965e9348 on AndrewSamokhvalov:litecoin_docker into 1124b45 on lightningnetwork:master.

coveralls · 2017-05-15T11:04:31Z

Coverage remained the same at 73.542% when pulling dd91d9423416d9af69c567acc7150a12c40a14c5 on AndrewSamokhvalov:litecoin_docker into 1124b45 on lightningnetwork:master.

Roasbeef

I've tested this out locally and the addition of lnd into the container configuration works just fine! However, I think we might need to modify the way we currently launch lnd as in this PR, it's still linked to btcd. This means that when docker-compose goes to build the alice or bob container, then btcd will always be built+run regardless of the environment variables we set.

Here's a proposal I think we resolve eveything:

Create distinct alice_CHAIN and bob_CHAIN containers in the docker-compose file. The CHAIN portion will either be btc, or ltcd, so there'll be alice_btc, bob_btc, `alice_ltc, etc.
In the btc or ltc container types for lnd, the link will be either to btcd or ltcd. * We may even want to scrap the bob+alice distinction all together. docker-compose` allows one to replicate a container template with a different name at launch time. So users will be able to name the containers w/e they want.

Roasbeef · 2017-05-17T21:37:59Z

docker/lnd/start-lnd.sh

+    "--$CHAIN.rpccert"="/rpc/rpc.cert" \
+    "--$CHAIN.active" \
+    "--$CHAIN.$NETWORK" \
+    "--$CHAIN.rpchost"="blockchain" \


The reference to blockchain here doesn't need to be scoped in an environment variable?

Tested this locally, and looks like it does indeed to to be scope somehow.

Run from inside the container:

root@aec17b768d6e:/go/src/github.com/lightningnetwork/lnd# ps xa PID TTY STAT TIME COMMAND 1 ? Ss 0:00 bash ./start-lnd.sh 11 ? Sl 0:04 lnd --datadir=/data --logdir=/data --bitcoin.rpccert=/rpc/rpc.cert --bitcoin.active --bitcoin.simnet --bitcoin.rpchost=blockchain --bitcoin.rpcuser=devuser --bitcoin.rpcpass=devpass --d 27 pts/0 Ss 0:00 bash 33 pts/0 R+ 0:00 ps xa

The point of interest is: --bitcoin.rpchost=blockchain, which means the string was passed through without any sort of substitution.

Actually scratch that. Not sure what happened before, but I'm able to properly connect now! Once the minor doc comments are addressed, I'll get this merged.

Roasbeef · 2017-05-17T21:39:16Z

docker/ltcd/Dockerfile

+# Expose segnet ports (server, rpc)
+EXPOSE 28901 28902
+
+# Grab and install the latest version of roasbeef's fork of btcd and all


Minor nit: comment needs to be updated.

Similar comment about the references to btcd as comment in the file.

coveralls · 2017-05-18T12:20:05Z

Coverage increased (+0.08%) to 73.621% when pulling a0f9ad6a2263ae546dd05b65b01b3cffc400a64c on AndrewSamokhvalov:litecoin_docker into 1124b45 on lightningnetwork:master.

Roasbeef

Took another pass of everything, the PR is nearly complete!

Two things remain

The documentation needs to be modified as is pointed out in-line.
Currently a container started using this PR can't connect to the running btcd node as the rpchost parameter isn't being passed through properly.

Roasbeef · 2017-07-03T21:10:24Z

docker/README.md

@@ -157,7 +157,7 @@ bob$ lncli listpeers
 Create the `Alice<->Bob` channel.
 ```bash
 # Open the channel with "Bob":
-alice$ lncli openchannel --node_key=<bob_identity_pubkey> --num_confs=1 --local_amt=1000000
+alice$ lncli openchannel --peer_id=1 --local_amt=1000000


The peer_id arguments are largely being phased out, why the change to identitfy by the peer ID? As is now, users won't be notified of the peer ID of a peer upon connection.

Roasbeef · 2017-07-03T21:11:24Z

docker/README.md

@@ -90,7 +90,7 @@ Connect `Bob` node to `Alice` node.

 ```bash
 # Run "Bob" node and log into it:
-$ docker-compose up --no-recreate -d "bob"
+$ docker-compose up --no-recreate -d --name "bob" "ltc_btc"


The last argument should instead be "lnd_btc".

Roasbeef · 2017-07-03T21:18:38Z

docker/README.md

@@ -64,7 +64,7 @@ bitcoin into.
 $ export NETWORK="simnet" 

 # Run the "Alice" container and log into it:
-$ docker-compose up -d "alice"
+$ docker-compose run -d --name alice "lnd_btc"


Quotes aren't needed around the "lnd_btc" argument, here or below.

Roasbeef · 2017-07-03T21:27:51Z

docker/lnd/start-lnd.sh

+    "--$CHAIN.rpccert"="/rpc/rpc.cert" \
+    "--$CHAIN.active" \
+    "--$CHAIN.$NETWORK" \
+    "--$CHAIN.rpchost"="blockchain" \


Tested this locally, and looks like it does indeed to to be scope somehow.

Run from inside the container:

root@aec17b768d6e:/go/src/github.com/lightningnetwork/lnd# ps xa PID TTY STAT TIME COMMAND 1 ? Ss 0:00 bash ./start-lnd.sh 11 ? Sl 0:04 lnd --datadir=/data --logdir=/data --bitcoin.rpccert=/rpc/rpc.cert --bitcoin.active --bitcoin.simnet --bitcoin.rpchost=blockchain --bitcoin.rpcuser=devuser --bitcoin.rpcpass=devpass --d 27 pts/0 Ss 0:00 bash 33 pts/0 R+ 0:00 ps xa

The point of interest is: --bitcoin.rpchost=blockchain, which means the string was passed through without any sort of substitution.

In order to make the installation process of the btcd robust we should use "glide" instead of "go get".

This parameter now might not belong to the Bitcoin network, because we introduce the Litecoin image soon.

Intoduce the Litecoin network daemon, which will be needed in order to interact with Litecoin blockchain.

After addition of the Litecoin client image (ltcd), we should add additional parameter to notify the start script which network we should use.

Create disctinct containers for Litecoin and Bitcoin, and also change the readme accordingly.

coveralls · 2017-07-04T20:49:30Z

Coverage decreased (-0.08%) to 74.016% when pulling 76cedac on AndrewSamokhvalov:litecoin_docker into c13e366 on lightningnetwork:master.

Roasbeef

LGTM 🛰

andrewshvv changed the title ~~Add litecoin docker image.container.~~ Add litecoin docker image and container. May 13, 2017

andrewshvv force-pushed the litecoin_docker branch 2 times, most recently from 1027636 to 9454bc6 Compare May 13, 2017 22:25

andrewshvv force-pushed the litecoin_docker branch from 9454bc6 to dd91d94 Compare May 15, 2017 10:57

Roasbeef requested changes May 17, 2017

View reviewed changes

Roasbeef requested changes Jul 3, 2017

View reviewed changes

andrewshvv added 5 commits July 4, 2017 23:25

docker: switch to use glide installation

90cc70a

In order to make the installation process of the btcd robust we should use "glide" instead of "go get".

docker: change BITCOIN_NETWORK -> NETWORK

12ee1ac

This parameter now might not belong to the Bitcoin network, because we introduce the Litecoin image soon.

docker: add ltcd image

5051c98

Intoduce the Litecoin network daemon, which will be needed in order to interact with Litecoin blockchain.

docker: add "CHAIN" parameter

f2ef30d

After addition of the Litecoin client image (ltcd), we should add additional parameter to notify the start script which network we should use.

docker: create distinct containers for blockchains

76cedac

Create disctinct containers for Litecoin and Bitcoin, and also change the readme accordingly.

andrewshvv force-pushed the litecoin_docker branch from a0f9ad6 to 76cedac Compare July 4, 2017 20:30

Roasbeef approved these changes Jul 5, 2017

View reviewed changes

Roasbeef merged commit e60a370 into lightningnetwork:master Jul 5, 2017

Roasbeef mentioned this pull request Jul 5, 2017

docker: switch to use glide installation #230

Closed

bretton mentioned this pull request Oct 13, 2020

lncli feereport fails with error "no policy for outgoing channel" from a previously cooperatively closed channel, and open channels #4690

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add litecoin docker image and container. #209

Add litecoin docker image and container. #209

andrewshvv commented May 13, 2017

mention-bot commented May 13, 2017

coveralls commented May 13, 2017

coveralls commented May 13, 2017 •

edited

Loading

coveralls commented May 15, 2017 •

edited

Loading

Roasbeef left a comment

Roasbeef May 17, 2017

andrewshvv May 18, 2017

Roasbeef Jul 3, 2017

Roasbeef Jul 4, 2017

Roasbeef May 17, 2017

Roasbeef May 17, 2017

coveralls commented May 18, 2017 •

edited

Loading

Roasbeef left a comment

Roasbeef Jul 3, 2017

Roasbeef Jul 3, 2017

Roasbeef Jul 3, 2017

Roasbeef Jul 3, 2017

coveralls commented Jul 4, 2017

Roasbeef left a comment

Add litecoin docker image and container. #209

Add litecoin docker image and container. #209

Conversation

andrewshvv commented May 13, 2017

mention-bot commented May 13, 2017

coveralls commented May 13, 2017

coveralls commented May 13, 2017 • edited Loading

coveralls commented May 15, 2017 • edited Loading

Roasbeef left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented May 18, 2017 • edited Loading

Roasbeef left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jul 4, 2017

Roasbeef left a comment

Choose a reason for hiding this comment

coveralls commented May 13, 2017 •

edited

Loading

coveralls commented May 15, 2017 •

edited

Loading

coveralls commented May 18, 2017 •

edited

Loading