Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to walletdb/bdb version w/ mmap pre-sizing #4243

Closed
wants to merge 4 commits into from
Closed

build: update to walletdb/bdb version w/ mmap pre-sizing #4243

wants to merge 4 commits into from

Commits on May 7, 2020

  1. build: update to walletdb/bdb version w/ mmap pre-sizing 

    In this commit, we update to the `walletdb/bdb` version that now has
mmap-pre-sizing. By sizing the memory map ahead of time, we aim to avoid
the mass copies in the DB each time we need to expand the size of the
DB. The new version will set the mmap size to 2x the db size, which
allows the DB to double before we need to remap everything.
    @Roasbeef
    Roasbeef committed May 7, 2020
    Configuration menu
    Copy the full SHA
    7a4613a View commit details
    Browse the repository at this point in the history

  2. multi: update to use new kvdb API

    @Roasbeef
    Roasbeef committed May 7, 2020
    Configuration menu
    Copy the full SHA
    bb94b76 View commit details
    Browse the repository at this point in the history

  3. channeldb/migration13: slight memory optimizations

    @Roasbeef
    Roasbeef committed May 7, 2020
    Configuration menu
    Copy the full SHA
    6c76351 View commit details
    Browse the repository at this point in the history

  4. channeldb/migration13: remove append usage for attemptInfo 

    In this commit, we attempt to optimize `migration13` further by no
longer appending the zero bytes to the `attemptInfo` slice in-place.
Internally, the append will attempt to double the backing slice capacity
if it needs to re-allocate in order to fulfil the append, which is the
case in this instance.

Instead, we make a new slice, with a precise size, then copy over the
trimmed `attemptInfo`. The new slice will have 8 zero bytes at the end.
    @Roasbeef
    Roasbeef committed May 7, 2020
    Configuration menu
    Copy the full SHA
    d29f1a8 View commit details
    Browse the repository at this point in the history