-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
routing: update route hints when seeing a ChannelUpdate msg #5218
Closed
yyforyongyu
wants to merge
17
commits into
lightningnetwork:master
from
yyforyongyu:2540-fix-retry-err
Closed
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
e0a9c2e
routing: make payment lifecycle test more verbose
yyforyongyu f3b9b19
routing: add private key attribute in router test
Bluetegu d35304d
routing: fix TestSendPaymentErrorRepeatedFeeInsufficient
Bluetegu f873c74
routing: test private edge on fee error
Bluetegu c74a754
routing: parse Channel ID from json file
yyforyongyu 5c3cd27
routing: rm hardcoded channel id in router test
yyforyongyu cd6f483
routing: use require in router test
yyforyongyu 5de0ca2
routing: use shardHandler to process err in SendToRoute
yyforyongyu ef12011
routing: move sendErr handling in shardHandler
yyforyongyu 45a288e
routing: add method UpdateAdditionalEdge and GetAdditionalEdgePolicy
yyforyongyu 4825afa
routing: make shardHandler aware of payment session
yyforyongyu 940ec75
routing: refactor TestSendPaymentErrorFeeInsufficientPrivateEdge
yyforyongyu 109e4da
routing: add TestSendPaymentPrivateEdgeUpdateFeeExceedsLimit
yyforyongyu 0b10206
itest: moving routing related tests into one file
yyforyongyu 04beb84
itest: fix make lint
yyforyongyu 98822a1
itest: test channel policy update in private channels
yyforyongyu 427fa22
itest: silence depreciation warnings
yyforyongyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW new tests don't really use the old static graph file and instead opt tin create a graph on the fly using some of the newly added test helpers. However I understand this was a revived PR and at the time of writing of this original commit, this was the only/preferred way to do things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. So are you suggesting we switch these tests to make the graph created on the fly in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And unrelated to this PR, we probably want to refactor old tests to get rid of the static graph file someday?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think it's a blocker, as this commit only exists as we salvaged the OG commit from the contributor.