release: create v0.17.4 rc1 release branch #8416
Conversation
|
Important Auto Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Add a unit test for the removal of a pending channel.
This adds an itest for a failed funding flow by our peer.
This commit fixes a heap escape found in `GetBlock`. This happens because the `msgBlock` is a pointer returned from `getBlockImpl`, and the whole `getBlockImpl` escapes to the heap because it's referenced in two places, - in the `Cache`, it's used as a reference type to create the new block. - this pointer is also returned and now needs to stay on the heap. The fix is simple, we now make a copy of the block and use the copy instead, freeing `getBlockImpl` from the heap.
Roasbeef
force-pushed
the
v0-17-4-branch
branch
from
0ba0748
to
08cb77c
Compare
|
Weird to see linter fails since we already disabled |
There was a problem hiding this comment.
LGTM 🎉
Weird to see linter fails since we already disabled paralleltest in 22600b4, which was included in 0.17.1, but couldn't find this commit here.
I can't see that commit in the lnd-17-1-branch. In fact, I don't see any changes to the linter config in this branch. So I think the linter breaking is expected and okay at this point.
|
can we possibly include #8437 as well? |
|
And #8428 too? |
Update the btcwallet version to fix a case where fetching of already pruned blocks from our peers was not garbage collected when the request failed.
Roasbeef
merged commit ed6f03e
into
lightningnetwork:v0-17-4-branch
Based on https://github.com/lightningnetwork/lnd/milestone/49
Includes:
btcdmempool leak fix andGetBlockheap escape #8401While making the branch, I realized that #8385 only applies on master. So that bug hadn't made it into an actual release yet. This was kept in with a slight modification. We can confirm if this is needed or not by running those added tests against the branch.
Similarly, part of the fix for #8400 only applies on master, as it relies on the new zombie ressurection logic.