fix sync neutrino nodes

[ziggie1984]

Replaces #8596.

Only dependant on: lightninglabs/neutrino#297

Although the instantiation of the NewPrunedBlockDispatcher happens in btcwallet which further instantiation the neutriono NewWorkManager its only necessary to bump the neutrino version into LND becaue golang will use the direct import not the version of neutrino which btcwallet imports.

Nonetheless we should also update the btcwallet to use the latest neutrino package but its not mandatory:
btcsuite/btcwallet#921

Fixes #8489

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ziggie1984]

@ellemouton done

[guggero]

LGTM pending nit and successful CI run

[guggero]

Neutrino itest failed with the following error:

     lnd_psbt_test.go:1013: testing with address type TAPROOT_PUBKEY and change address type CHANGE_ADDRESS_TYPE_P2TR
    lnd_channel_force_close_test.go:412: 
        	Error Trace:	/home/runner/work/lnd/lnd/itest/lnd_channel_force_close_test.go:412
        	            				/home/runner/work/lnd/lnd/itest/lnd_channel_force_close_test.go:84
        	Error:      	Received unexpected error:
        	            	expected 330 to be recovered
        	Test:       	TestLightningNetworkDaemon/tranche01/53-of-149/neutrino/channel_force_closure/committype=SIMPLE_TAPROOT
        	Messages:   	timeout while checking force closed channel

Logs available here: https://github.com/lightningnetwork/lnd/actions/runs/8820468642/artifacts/1445075063

Going to re-run to see if it's just a flake.

[yyforyongyu]

Neutrino itest failed with the following error:

Yea it's a flake and I'm currently working on fixing it.

[ziggie1984]

Updated the neutrino version to the latest master version.

[Roasbeef]

LGTM 🥫