Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initizalize test framework #57

Merged
merged 8 commits into from
Mar 18, 2024
Merged

Initizalize test framework #57

merged 8 commits into from
Mar 18, 2024

Conversation

julkunensuvi
Copy link
Contributor

Decided to include only unit testing. Chose Jest as a tool

@julkunensuvi julkunensuvi linked an issue Mar 14, 2024 that may be closed by this pull request
Copy link
Contributor

@rafinutshaw rafinutshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kindly add these tests to github actions as well. Github actions shouldnt allow merge if tests fail.

package.json Outdated Show resolved Hide resolved
tests/core/structure/sheet.test.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@rafinutshaw rafinutshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this warning when i run "npm run test". Kindly looking to this as well

image

@rafinutshaw
Copy link
Contributor

This branch has is not updated with the latest main branch. Kindly update with the main branch and resolve conflicts.
Thanks.

@julkunensuvi julkunensuvi linked an issue Mar 18, 2024 that may be closed by this pull request
@julkunensuvi
Copy link
Contributor Author

Fixed the issues and added testing to the github workflow. Linked the github actions issue to the PR as well
#11
@rafinutshaw @GimanthaDissanayake

@rafinutshaw
Copy link
Contributor

LGTM!

@Yousif-FJ Yousif-FJ merged commit 2b38c07 into main Mar 18, 2024
2 checks passed
@Yousif-FJ Yousif-FJ deleted the initizalize-test-framework branch May 3, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initizalize test framework Setup GitHub Actions for tests
3 participants