Destructure css and classname to Checkbox/Radio wrapper components #55
Conversation
|
Deploy preview for lightspeed-flame ready! Built with commit 3c4820d |
| display: -webkit-inline-box; | ||
| display: -webkit-inline-flex; | ||
| display: -ms-inline-flexbox; | ||
| display: inline-flex; |
There was a problem hiding this comment.
Why has this changed to inline-flex?
| @@ -29,7 +29,7 @@ const FormHelper: React.FC<FormHelperProps> = ({ status, children, ...restProps | |||
|
|
|||
| export type BaseLabelProps = React.HTMLAttributes<HTMLLabelElement> & TextProps & { css?: any }; | |||
| const BaseLabel = styled(Text)<BaseLabelProps>` | |||
| display: flex; | |||
| display: inline-flex; | |||
There was a problem hiding this comment.
Oh, because of here. But why was this done as part of this PR?
There was a problem hiding this comment.
Labels should be inlined, not block by default.
This is to match up with regular styling.
|
|
||
| .zIndex-2 { | ||
| z-index: 2; | ||
| } |
|
Also should we rename the PR subject to include only Radio and Checkbox? |
xdrdak
changed the title
|
I've added comments on the Percy build regarding visual changes (all related to |
|
I would actually scope out the |
|
I'll remove the inline flex thing. causes too many regressions |
Description
CSS prop and className prop was not getting forwarded to the right component.
This PR will now ship the right props to the right components.
How to test?
yarn devChecklist