Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variations dialogue #192

Open
smellymoo opened this issue Dec 7, 2016 · 8 comments
Open

Variations dialogue #192

smellymoo opened this issue Dec 7, 2016 · 8 comments

Comments

@smellymoo
Copy link

I use gobandroid primarily to play go with someone while out and about...

It is incredibly annoying when you are showing someone how to play and you click undo, then you get variations dialogue, then "disable" popup. Bad user experience.

Instead I suggest a simpler solution of having [yes|no|never] for the dialogue.

It would greatly increase my happiness and would take less lines of code :).

Thanks.

@smellymoo
Copy link
Author

P.s.

Settings > show variations dialogue

When set to false should probably not even show the dialogue when clicking "undo" anyway.

@ligi
Copy link
Owner

ligi commented Dec 7, 2016

I had it like this before - but found this way to be better in terms of discoverability and non-intrusiveness - the toast should not really intrude but always give you the option .. Not yet convinced that I should go back to the old way

@ligi ligi added the undecided label Dec 7, 2016
@smellymoo
Copy link
Author

Huh? It intrudes... I'm certain you must be thinking about something else...

It's a standard alert that pops up in the center when you undo a move then place a new one. Totally annoying...

  1. undo
  2. new move
  3. central popup dialog: "Do you want to save this as a variation?" (Yes/no)
  4. select no
  5. bottom bar "disable variations dialogue" (disable)

That is really terrible user experience.

Possible solutions:
-bottom bar asking "keep variation?" (Save). This is best as it needs no clicks. You could even add (never) then it doesn't even annoy you.
-the setting "show variations dialogue" when disabled it could not show any dialog, which I think is a bug.
-the alert could have "never" in as an option.

When I'm using it with a noob, explaining nice variations becomes a chore, really there should be no bar to undo the redo, so first 2 options win for me.

@ligi
Copy link
Owner

ligi commented Dec 7, 2016 via email

@smellymoo
Copy link
Author

Why do I get the dialog when the setting for it is disabled in settings then? Bug for sure.

And if I am really misunderstanding what "show variations dialogue" is supposed to mean, can it not be the bottom bar instead of system modal alert?

It's big enough of an annoyance that I might do it myself and do a pull request. But I'm quite busy with my apps :(

@ligi
Copy link
Owner

ligi commented Dec 7, 2016 via email

@gthazmatt
Copy link
Contributor

I use this app on a weekly basis, and I didn't realize that there was an option in the toast message to disable the variation dialogue until I came across this issue a few days ago. I just assumed that you had removed the option. I'm with smellymoo and think that the check box on the dialogue was much better.

@ligi
Copy link
Owner

ligi commented Mar 12, 2017

Good to know - I should really measure here - ideally with an A/B test ( a/b might here just to switch the default value for a while and see which one gets used more )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants