Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish for scalajs-0.6.1 #72

Closed
ramnivas opened this issue Mar 4, 2015 · 6 comments
Closed

Republish for scalajs-0.6.1 #72

ramnivas opened this issue Mar 4, 2015 · 6 comments

Comments

@ramnivas
Copy link
Contributor

ramnivas commented Mar 4, 2015

To ensure that uPickle users benefit from scala-js/scala-js#1506 (and avoid symptoms seen in scala-js/scala-js#1514), uPickle needs to be republished for scalajs-0.6.1.

@dispalt
Copy link

dispalt commented Mar 4, 2015

Do you need to recompile to fix the problem or is it just a dependency
thing?

-Dan

On Tue, Mar 3, 2015 at 6:15 PM, Ramnivas Laddad notifications@github.com
wrote:

To ensure that uPickle users benefit from scala-js/scala-js#1506
scala-js/scala-js#1506 (and avoid symptoms
seen in scala-js/scala-js#1514
scala-js/scala-js#1514), uPickle needs to be
republished for scalajs-0.6.1.


Reply to this email directly or view it on GitHub
#72.

@ramnivas
Copy link
Contributor Author

ramnivas commented Mar 4, 2015

I believe the following patch needs to be applied (bumped product version too, since I am not sure republishing a published artifact is allowed or even a good idea). BUT... when I tried to sbt publishLocal, I got unresolved com.lihaoyi#utest_sjs0.6_2.10;0.2.5, thus not making a PR off of it.

diff --git a/build.sbt b/build.sbt
index 6d534a1..70d7658 100644
--- a/build.sbt
+++ b/build.sbt
@@ -2,7 +2,7 @@ crossScalaVersions := Seq("2.10.4", "2.11.4")

 val upickle = crossProject.settings(
   organization := "com.lihaoyi",
-  version := "0.2.6",
+  version := "0.2.7",
   scalaVersion := "2.10.4",
   name := "upickle",
   scalacOptions := Seq("-unchecked",
diff --git a/project/build.sbt b/project/build.sbt
index 40a67d6..0dd657b 100644
--- a/project/build.sbt
+++ b/project/build.sbt
@@ -1 +1 @@
-addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.0")
+addSbtPlugin("org.scala-js" % "sbt-scalajs" % "0.6.1")

@lihaoyi
Copy link
Member

lihaoyi commented Mar 4, 2015

I'm also not clear. @sjrd does this mean the generated IR changed with that fix?

@sjrd
Copy link
Contributor

sjrd commented Mar 4, 2015

Yes the generated IR changed. It's still compatible, though, in the sense that the linker of 0.6.0 can read .sjsir files produced by 0.6.1 and vice versa. Basically the output of the 0.6.0 compiler was buggy. So yes a recompilation is needed. It is not just a dependency thing, otherwise I would not have told you in the first place.

@lihaoyi
Copy link
Member

lihaoyi commented Mar 4, 2015

Ok cool, I'll give everything a recompile next pass

@lihaoyi
Copy link
Member

lihaoyi commented Mar 9, 2015

This has happened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants