Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflict with dama/doctrine-test-bundle #15

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

alexislefebvre
Copy link
Collaborator

@alexislefebvre alexislefebvre commented Jun 11, 2019

See liip/LiipFunctionalTestBundle#423


Test code from this branch:

  1. Add this in your composer.json file:
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/liip/LiipTestFixturesBundle.git"
        }
    ]
  1. composer require --dev liip/test-fixtures-bundle:dev-fix-conflict-with-dama-doctrine-test-bundle
  2. Set liip_test_fixtures.keep_database_and_schema: true in your configuration

@scaytrase
Copy link

I can confirm that this patch fixes issues other than dama/doctrine-test-bundle compatibility (I have it installed but don't have these issues before).

@alexislefebvre
Copy link
Collaborator Author

@scaytrase Thanks for the test!

@alexislefebvre alexislefebvre merged commit 3fd247f into master Jul 15, 2019
@alexislefebvre alexislefebvre deleted the fix-conflict-with-dama-doctrine-test-bundle branch July 15, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants