📱 Fix in-app notification & improve loading UX #1045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nwingt
commented
Apr 21, 2023
Comment on lines
+95
to
-102
| <FollowerDialog | ||
| :is-open-followers-dialog="isOpenFollowersDialog" | ||
| :wallet-is-fetching-followers="walletIsFetchingFollowers" | ||
| :populated-followers="populatedFollowers" | ||
| @close="isOpenFollowersDialog = false" | ||
| @on-export-followers="handleClickExportFollowerList" | ||
| /> | ||
| </AuthRequiredView> | ||
|
|
||
| <FollowerDialog | ||
| :is-open-followers-dialog="isOpenFollowersDialog" | ||
| :wallet-is-fetching-followers="walletIsFetchingFollowers" | ||
| :populated-followers="populatedFollowers" | ||
| @close="isOpenFollowersDialog = false" | ||
| @on-export-followers="handleClickExportFollowerList" | ||
| /> |
There was a problem hiding this comment.
<FollowerDialog> must be inside the <AuthRequiredView/> to make <AuthRequiredView/> reactive...don't know why
Comment on lines
+161
to
-167
| get progressContainerClasses() { | ||
| return [ | ||
| 'text-like-cyan-light', | ||
| { 'text-shade-gray': this.preset === ProgressIndicatorPreset.Thin }, | ||
| 'fill-like-cyan-light', | ||
| ]; | ||
| } | ||
|
|
||
| get progressContainer() { | ||
| return { | ||
| class: [ | ||
| 'text-like-cyan-light', | ||
| { 'text-shade-gray': this.preset === ProgressIndicatorPreset.Thin }, | ||
| 'fill-like-cyan-light', | ||
| ], |
There was a problem hiding this comment.
Using an object with key class is not flattened with v-bind, so I move the class array to separated computed prop
williamchong
requested changes
Apr 21, 2023
src/components/AuthRequiredView.vue
Outdated
| <div class="flex justify-center mt-[24px]"> | ||
| <ProgressIndicator v-if="walletIsLoggingIn" /> | ||
| <div class="flex flex-col items-center mt-[24px]"> | ||
| <template v-if="isLoadingAtStart || walletIsLoggingIn"> |
There was a problem hiding this comment.
Maybe isShowConnectButton = false is easier to read? isLoadingAtStart is confusing but I have no better suggestions
There was a problem hiding this comment.
Hmm, my purpose is not hiding connect button, this is solving the blinking UI before walletIsLoggingIn changes to true, how about isLoadingStartImmediately, like the immediate: true in watch?
williamchong
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.