-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 Display followed alert upon verification #1071
Merged
williamchong
merged 6 commits into
likecoin:develop
from
AuroraHuang22:feature/better-verify-email
May 10, 2023
Merged
🚸 Display followed alert upon verification #1071
williamchong
merged 6 commits into
likecoin:develop
from
AuroraHuang22:feature/better-verify-email
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AuroraHuang22
commented
May 9, 2023
- Link to gmail/yahoo/proto/apple if we know
- After verification, if a creator is automatically followed, should show the followed alert
AuroraHuang22
added a commit
that referenced
this pull request
May 9, 2023
AuroraHuang22
force-pushed
the
feature/better-verify-email
branch
from
May 9, 2023 02:07
e145219
to
397a116
Compare
AuroraHuang22
added a commit
that referenced
this pull request
May 9, 2023
AuroraHuang22
force-pushed
the
feature/better-verify-email
branch
from
May 9, 2023 02:32
397a116
to
916b029
Compare
AuroraHuang22
added a commit
that referenced
this pull request
May 9, 2023
williamchong
requested changes
May 9, 2023
AuroraHuang22
force-pushed
the
feature/better-verify-email
branch
from
May 9, 2023 14:43
058b16a
to
97c9073
Compare
nwingt
approved these changes
May 10, 2023
nwingt
reviewed
May 10, 2023
@@ -166,6 +167,25 @@ export default { | |||
} | |||
return 'portfolio_follow_hint'; | |||
}, | |||
unverifiedEmailLink() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this, unverifiedEmailLink
seems ambiguous to me
Suggested change
unverifiedEmailLink() { | |
checkEmailLink() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.