Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Do not load notification details on login #1204

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

williamchong
Copy link
Member

@williamchong williamchong commented Jul 8, 2023

Notifications events are loaded whenever user is logged in or load likerland with a session
Now this is causing huge performance issue for user with loads of notifcations since all NFT metadata are fetched whenever a likerland page is opened

@williamchong williamchong temporarily deployed to rinkeby July 8, 2023 07:35 — with GitHub Actions Inactive
@williamchong williamchong marked this pull request as ready for review July 8, 2023 19:03
@williamchong williamchong temporarily deployed to main July 8, 2023 20:39 — with GitHub Actions Inactive
@williamchong williamchong temporarily deployed to rinkeby July 9, 2023 14:57 — with GitHub Actions Inactive
williamchong added a commit that referenced this pull request Jul 9, 2023
@williamchong williamchong requested a review from nwingt July 9, 2023 19:44
@williamchong williamchong merged commit df1a7a7 into likecoin:develop Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants