Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAS-154] ⚡️ Combine all /class API of followees in one #1264

Merged
merged 5 commits into from
Aug 1, 2023
Merged

[TAS-154] ⚡️ Combine all /class API of followees in one #1264

merged 5 commits into from
Aug 1, 2023

Conversation

WeiJun0827
Copy link
Contributor

No description provided.

@notion-workspace
Copy link

WeiJun0827 added a commit that referenced this pull request Jul 31, 2023
Copy link
Member

@williamchong williamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this would break when we have too many iscn_owner and the url is too long
Can we split the API calls if the followee count is > 50?

williamchong added a commit that referenced this pull request Jul 31, 2023
@WeiJun0827
Copy link
Contributor Author

WeiJun0827 commented Aug 1, 2023

Note that this would break when we have too many iscn_owner and the url is too long Can we split the API calls if the followee count is > 50?

EDIT:
Below discussion is for browsers. But I think the max allowed length for servers like Nginx could be set to 4k or 8k, so 50 followees would be fine?


I would need to be worried about this.
The length of one qs set(&iscn_owner=like1xxx) is 55 chars, and the max length of an URL is around 2000. Is it better to set the batch size at 30?

@williamchong
Copy link
Member

Note that this would break when we have too many iscn_owner and the url is too long Can we split the API calls if the followee count is > 50?

EDIT: Below discussion is for browsers. But I think the max allowed length for servers like Nginx could be set to 4k or 8k, so 50 followees would be fine?

I would need to be worried about this. The length of one qs set(&iscn_owner=like1xxx) is 55 chars, and the max length of an URL is around 2000. Is it better to set the batch size at 30?

Lets do 30, we are still firing from frontend for now

WeiJun0827 added a commit that referenced this pull request Aug 1, 2023
@williamchong williamchong merged commit 2312bdc into likecoin:develop Aug 1, 2023
1 check passed
@WeiJun0827 WeiJun0827 deleted the feature/improve-followee-api-perf branch August 3, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants