Ignore quoted forms when searching for hooks #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilactown
requested changes
Jun 30, 2021
Previously, a component containing a quoted form with a hook in would
have been caught by the hooks detection (example below). Additionally,
avoiding the postwalk improves the performance of the find-hooks
function.
```
(defnc foo
[]
(d/div
(d/h1 "Usage example")
(d/code (pr-str '(use-foo)))))
```
SevereOverfl0w
force-pushed
the
ignore-quoted
branch
from
098c73d
to
7b2637c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a component containing a quoted form with a hook in would
have been caught by the hooks detection (example below). Additionally,
avoiding the postwalk improves the performance of the find-hooks
function.