Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Morse Code Decoder Methods #3

Merged
merged 7 commits into from
Nov 10, 2023
Merged

Morse Code Decoder Methods #3

merged 7 commits into from
Nov 10, 2023

Conversation

lily4178993
Copy link
Owner

Morse Code Decoder Methods

This pull request adds methods for decoding Morse code into characters, words, and messages.

Implemented Methods:

  1. decode_char: Transforms a Morse code character to uppercase (e.g., decode_char(".-") returns "A").
  2. decode_word: Decodes a Morse code word (e.g., decode_word("-- -.--") yields "MY").
  3. decode: Decodes a Morse code message (e.g., decode("-- -.-- -. .- -- .") results in "MY NAME").

Key Implementation:

  • Emphasized code reusability and modular decoding methods.

Please review this pull request at your earliest convenience. Your feedback is greatly appreciated.

Thank you for your time and consideration.

Copy link

@Felix45 Felix45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🟢

Hi @lily4178993 , @richie1988 & @rmiyoyo

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights ✔️

  • Good use of functions ✅
  • Application functions as expected ✅
  • Git flow is used correctly ✅
  • Pull request has a descriptive title and summary ✅
  • Repository has a professional readme file ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@rmiyoyo rmiyoyo merged commit 275f166 into dev Nov 10, 2023
1 check passed
@lily4178993
Copy link
Owner Author

Thank you @Felix45 for your review and feedback

@lily4178993 lily4178993 deleted the features/decode-message branch November 10, 2023 14:30
Repository owner locked as resolved and limited conversation to collaborators Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants