Return error when template expansion fails #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Dubois <jan.dubois@suse.com>
jandubois
added a commit
to rancher-sandbox/lima-and-qemu
that referenced
this pull request
Sep 28, 2022
to get the error message when `fd_connect` fails (to help debugging lima-vm/socket_vmnet#7). Signed-off-by: Jan Dubois <jan.dubois@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I could not determine what triggered this error, but I've run into it while testing Rancher Desktop with socket_vmnet, and qemu failed because it had a
-netdevoption withoutidin the value (there was no value at all).I've not been able to reproduce it again since I fixed the error reporting.