pkg/cidata: During boot, only terminate user connections when the environment changes #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandubois
requested changes
Dec 3, 2023
There was a problem hiding this comment.
The lint step in CI (shfmt) is complaining about the formatting of your changes.
But I think the whole change can be simplified.
I can't think of any reason why removing the old socket would be useful, so I'm fine with deleting that code unless another maintainer speaks up about it.
|
Can you please squash commits? At least the first and last commit should be combined into a single commit. |
Signed-off-by: mhio <37205532+mhio@users.noreply.github.com>
for lima-vm#1941 Signed-off-by: mhio <37205532+mhio@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1941