[release/0.20] alpine: avoid wiping out writable host mounts under /home, etc #2244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix parsing ssh keys as block string * Create a mount script instead of editing /etc/fstab * Make lima-init.sh yaml parsing more robust Signed-off-by: Jan Dubois <jan.dubois@suse.com> (cherry picked from commit 9a10748) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
A host directory could be wiped out when all the following conditions are met: - The directory is mounted to Lima via virtiofs or 9p (reverse-sshfs is not affected) - The mount is writable - The mount point in the guest is under one of: /etc /home /root /usr/local /var/lib - The guest OS is Alpine Linux Fix issue 2221 Fix rancher-sandbox/rancher-desktop issue 6582 Co-authored-by: Jan Dubois <jan.dubois@suse.com> Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> (cherry picked from commit 795ada2) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
The escaping is needed to print the string with quotes, but would break the umount command. Signed-off-by: Jan Dubois <jan.dubois@suse.com> (cherry picked from commit a782327) Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick (clean):