-
Notifications
You must be signed in to change notification settings - Fork 15
View options #20
Comments
I agree, this would be a great feature. And thank you. :) |
By putting the Control into a ScrolledWindow, we get scroll bars whenever the Control's container is smaller than its minimum size. Vertical scrolling of the ScrolledWindow currently is deactivated, as we still have our custom implementation for vertical scrolling. This, however, raises some issues: At first, the vertical scroll bar gets scrolled away along with the Screenplay Control while scrolling horizontally, as it is part of the contents of the ScrolledWindow. Also, the hand-made scrollbar lacks some features, such as auto-hiding or the "precise scrolling mode" on Gtk. Eventually, the custom scrolling implementation is probably going to get in our way when implementing limburgher#20 anyway, so we should try to port vertical scrolling to the ScrolledWindow scrolling mechanism.
@TheScooterKing Are you still waiting for this feature? I'm asking because before we can implement zooming, we need to implement horizontal scrolling. There are 2 approaches to do this, one is a bit more "hacky" but will be pretty easy to implement, the other approach (#72) needs a huge restructuring of a lot of code, but leads to a more clean result and also a lot of other features "for free". If I don't know whether there are even users who need this feature, I'll probably just try every now and then to continue my experiment with the huge solution, and not start any other attempts until that is finished (maybe never). If I knew there are still users waiting for this, I'd take a more realistic approach that could bring zooming to the Trelby canvas in the foreseeable future. |
Thank you for porting this new version! |
@ClaudiusMinimus Thanks for the feedback! Then I'm going to attempt to implement it in the simpler way. I hope to get zoom working during the next weeks. |
By putting the Control into a ScrolledWindow, we get scroll bars whenever the Control's container is smaller than its minimum size. Vertical scrolling of the ScrolledWindow currently is deactivated, as we still have our custom implementation for vertical scrolling. This, however, raises some issues: At first, the vertical scroll bar gets scrolled away along with the Screenplay Control while scrolling horizontally, as it is part of the contents of the ScrolledWindow. Also, the hand-made scrollbar lacks some features, such as auto-hiding or the "precise scrolling mode" on Gtk. Eventually, the custom scrolling implementation is probably going to get in our way when implementing limburgher#20 anyway, so we should try to port vertical scrolling to the ScrolledWindow scrolling mechanism.
Hello! This repository is merging into https://github.com/trelby/trelby. Please check your issue against the current code there. If the issue is still relevant, please open a version of this issue there and close this issue. If not, just close this issue. All issues in this repository that are still open in 30 days will be closed. Thank you! |
I'm a bit visually impaired, so it would be useful to me to see a view option for zoom, or even just fit to page width.
Glad to see that you've taken up the torch with this app.
The text was updated successfully, but these errors were encountered: