Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command: title_case #72

Closed
quarnster opened this issue Oct 31, 2013 · 4 comments
Closed

Command: title_case #72

quarnster opened this issue Oct 31, 2013 · 4 comments

Comments

@quarnster
Copy link
Member

No description provided.

quarnster added a commit that referenced this issue Nov 20, 2013
Adding Commands for Swap Case and Title Case. Fixes #73. Let's keep #72 open until the "He'Ll" is fixed either by the go team or us
@quarnster
Copy link
Member Author

@arbrown Did you file a Go issue? What's the issue number? If they accept it, lets just close this one as there won't be anything to do here in the future then.

@arbrown
Copy link
Contributor

arbrown commented Nov 20, 2013

I didn't file an issue, but I looked in to it, and it's a known bug, and is even documented in the source code here: https://code.google.com/p/go/source/browse/src/pkg/strings/strings.go#485 . I'll search the issue tracker a little bit more thoroughly to see if there is an issue to back the bug in the source, and add one if there is not. I might even be able to submit a patch to fix it. Unicode word-breaking algorithms are more complicated than checking isSeparator for every character (which is what the go team did there) but it's not that bad...

@arbrown
Copy link
Contributor

arbrown commented Nov 21, 2013

I've filed a go issue:
https://code.google.com/p/go/issues/detail?id=6801
And I've started a dialog on the go mailing list about adding proper word boundary detection. I suspect this will take a while to resolve. I have some ideas for implementing it, but I'd rather not do that whole thing just for a simple command in lime. I think I'll just write a modified version of their title case command that does not consider apostrophes word boundaries.

@RoelVanNyen
Copy link
Contributor

This has been implemented allready.
It has one small issue but that does not mean we should keep this open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants