Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qml main.go file decomposition #504

Merged
merged 6 commits into from
Feb 25, 2015
Merged

Conversation

bwiggs
Copy link
Contributor

@bwiggs bwiggs commented Feb 25, 2015

The qml/main.go was getting pretty large, so I moved all the different types to their own files and cleaned up the imports, var, and const declarations.

One side effect of this is that you can't just run go run main.go, because you have to list out each file individually. Instead use:

go build && ./qml
go run main.go frontend_view.go frontend_window.go qml_frontend.go keys.go qml_dialog.go

Happy to address any feedback.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.16%) to 62.58% when pulling 6059eae on bawigga:main-decomposition into bb3e751 on limetext:master.

@bwiggs
Copy link
Contributor Author

bwiggs commented Feb 25, 2015

Also, I'm a bit of a golang newb. So if this isn't very gopher like I understand.

quarnster added a commit that referenced this pull request Feb 25, 2015
@quarnster quarnster merged commit 9cf4952 into limetext:master Feb 25, 2015
@quarnster
Copy link
Member

LGTM, thanks!

@bwiggs bwiggs deleted the main-decomposition branch February 25, 2015 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants