forked from apache/james-project
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
James 1860 refactor #485
Closed
Closed
James 1860 refactor #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
force-pushed
the
JAMES-1860-refactor
branch
3 times, most recently
from
November 23, 2016 08:58
f5bf104
to
b353275
Compare
chibenwa
force-pushed
the
JAMES-1860-refactor
branch
from
November 24, 2016 02:11
546d12c
to
9f48676
Compare
test this please |
2 similar comments
test this please |
test this please |
Error seems linked to an unmerged pull request :
How is that possible ? (https://james.open-paas.org/job/build%20pull-requests/670/)
Looks like we end up with configuration from an other PR. My hint about that :
We need to prefix such directories with buildId. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can vote for the following refactors :
I vote for 1, 2, 3.
I downvote 4 as it implies a lot of copies. Or changing Message to hold a ShareInputStream (which also implies copy). I'm in favor of saving perfs, at the cost of "yet an other Message like class" that is not a Message because it has a SharedInputStream. Any comment welcomed.