James 1860 refactor

[chibenwa]

We can vote for the following refactors :

• 1: Extracting (and test) flags operations
• 2: Extracting (and test) mimeMessage parsing
• 3: Rely on a provider for PERMANENT FLAGS
• 4: MimeMessageReader should return a message

I vote for 1, 2, 3.

I downvote 4 as it implies a lot of copies. Or changing Message to hold a ShareInputStream (which also implies copy). I'm in favor of saving perfs, at the cost of "yet an other Message like class" that is not a Message because it has a SharedInputStream. Any comment welcomed.

[chibenwa]

test this please

[chibenwa]

test this please

[chibenwa]

test this please

[chibenwa]

Error seems linked to an unmerged pull request :

09:19:03.732 [ERROR] o.a.j.m.i.c.CamelCompositeProcessor - Unable to init mailet Metrics: javax.mail.MessagingException: Can not load mailet Metrics;
  nested exception is:
	java.lang.ClassNotFoundException: org.apache.james.transport.mailets.Metrics

How is that possible ?

(https://james.open-paas.org/job/build%20pull-requests/670/)

• GitHub pull request James 1860 refactor #485 of commit 9f48676

Looks like we end up with configuration from an other PR.

My hint about that :

• We use the same workspace
• Our build is dockerized, hence conflict free
• But we use the same local folders for :
  • Copying binaries
  • And config files

We need to prefix such directories with buildId.