Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TF-1417 Remove Plain/Text when create signature #1484

Merged
merged 2 commits into from
Feb 22, 2023
Merged

TF-1417 Remove Plain/Text when create signature #1484

merged 2 commits into from
Feb 22, 2023

Conversation

nqhhdev
Copy link
Member

@nqhhdev nqhhdev commented Feb 20, 2023 •
edited

#1417 , #1467 , #1476

  • Remove Plain/Text when create signature

Demo

MOBILE

Simulator.Screen.Recording.-.iPhone.14.-.2023-02-20.at.23.13.36.mp4

WEB

Screen.Recording.2023-02-20.at.22.54.29.mov

@dab246 dab246 changed the title Remove Plain/Text when create signature TF-1417 Remove Plain/Text when create signature Feb 20, 2023
@nqhhdev nqhhdev temporarily deployed to dev February 20, 2023 07:11 — with GitHub Actions Inactive
@nqhhdev nqhhdev temporarily deployed to dev February 20, 2023 07:11 — with GitHub Actions Inactive
@nqhhdev
Copy link
Member Author

nqhhdev commented Feb 20, 2023

add Padding to ToolbarRichTextWebBuilder

Screen.Recording.2023-02-20.at.22.52.53.mov

@nqhhdev nqhhdev temporarily deployed to dev February 20, 2023 16:27 — with GitHub Actions Inactive
@nqhhdev nqhhdev temporarily deployed to dev February 20, 2023 16:27 — with GitHub Actions Inactive
@hoangdat
Copy link
Member

for #1467, please demo the case:

user X is a member of team mailbox Y (teamY@domain.com),
user X want to create identity for the team mailbox with email (teamY@domain.xom)

@nqhhdev
Copy link
Member Author

nqhhdev commented Feb 21, 2023

for #1467, please demo the case:

user X is a member of team mailbox Y (teamY@domain.com),
user X want to create identity for the team mailbox with email (teamY@domain.xom)

It will be moved to this ticket #1488

dab246
dab246 approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@dab246 dab246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dab246 dab246 merged commit 3ec1035 into master Feb 22, 2023
@dab246 dab246 deleted the feature/TF-1417-only-use-html-text-for-signature-when-create-identity branch February 24, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangdat hoangdat hoangdat approved these changes

@dab246 dab246 dab246 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nqhhdev @hoangdat @dab246