-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tw 1900: IOS is forced to log out many times #1921
Conversation
…dd try/catch for read/write keychain data
This PR has been deployed to https://linagora.github.io/twake-on-matrix/1921 |
Can you reproduce issue 100%? |
Yeah. 100% now |
Screen.Recording.2024-07-05.at.10.28.17.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test on iOS but this looks good. @nqhhdev could you test it please ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was built it and test on my iphone. LGMT
Issue:
#1900
How to reproduce:
in your iphone, lock the iphone and make sure the Twake Chat is terminated. Wait for a notification from encrypted room to come, when the notification appear in the screen, wait for 5-10 second, then unlock the iphone, click the notification, the user will be redirect to /twakeWelcome page.
Logs:
Root cause:
Solution:
add a try/catch in the write operation to keychain, so that if its failed, it still return the old client. Make the access to keychain storage to lowest (which is KeychainAccessibility.first_unlock_this_device), this will make sure we don't hvae this error anymore.
Demo:
RPReplay_Final1720133037.MP4