Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Changed mbedtls function names to prevent symbol conflicts #2

Merged
merged 2 commits into from
May 31, 2024
Merged

Bugfix: Changed mbedtls function names to prevent symbol conflicts #2

merged 2 commits into from
May 31, 2024

Conversation

juh0ng
Copy link
Contributor

@juh0ng juh0ng commented May 30, 2024 •
edited
Loading

  • Minor issues in lib/README.md are fixed
  • Changed mbedtls function names to prevent symbol conflicts

@juh0ng juh0ng requested a review from tiod4420 May 30, 2024 05:46
@juh0ng juh0ng self-assigned this May 30, 2024
tiod4420
tiod4420 reviewed May 30, 2024
View reviewed changes
lib/src/aes_gcmsiv.c Outdated Show resolved Hide resolved
tiod4420
tiod4420 requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@tiod4420 tiod4420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good! But if possible, could we also rename the name of the mbedtls field in the union to generic?

@juh0ng juh0ng changed the title Bugfix: mbedtls prefix replaced with generic to prevent symbol conflicts Bugfix: Changed mbedtls function names to prevent symbol conflicts May 30, 2024
@juh0ng juh0ng requested a review from tiod4420 May 30, 2024 09:10
tiod4420
tiod4420 approved these changes May 31, 2024
View reviewed changes
Copy link
Contributor

@tiod4420 tiod4420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@tiod4420 tiod4420 merged commit b427f29 into line:dev May 31, 2024
5 checks passed
@juh0ng juh0ng deleted the bugfix/symbol-conflict branch May 31, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiod4420 tiod4420 tiod4420 approved these changes

Assignees

@juh0ng juh0ng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juh0ng @tiod4420