Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default maxFrameLength differs between client and server side #118

Closed
trustin opened this issue Mar 3, 2016 · 1 comment
Closed

Default maxFrameLength differs between client and server side #118

trustin opened this issue Mar 3, 2016 · 1 comment
Assignees
@trustin
Labels
defect
Milestone
0.11.0.Final

Comments

@trustin
Copy link
Member

trustin commented Mar 3, 2016

10MB vs 1MB. We should use the sensible identical default value. Suggestions?
/cc @anuraaga @inch772
@trustin trustin added the defect label Mar 3, 2016
@trustin trustin added this to the 0.11.0.Final milestone Mar 3, 2016
@anuraaga
Copy link
Collaborator

anuraaga commented Mar 3, 2016

It's hard to say anything for certain, but my feeling is that 1MB seems pretty small and 10MB seems pretty big, so 10MB? :)

trustin added a commit to trustin/armeria that referenced this issue Mar 4, 2016
@trustin
Use the same default maxFrameLength for both sides
c14123d 
Motivation:

The current default maxFrameLength values for client and server are 10
MB and 1 MB respectively. Having different default values gives a user
surprises.

Modifications:

Use the same default maxFrameLength value (10 MB) for client and server

Result:

Fixes line#118
@trustin trustin mentioned this issue Mar 4, 2016
Merged
trustin added a commit to trustin/armeria that referenced this issue Mar 4, 2016
@trustin
Use the same default maxFrameLength for both sides
784f969 
Motivation:

The current default maxFrameLength values for client and server are 10
MB and 1 MB respectively. Having different default values gives a user
surprises.

Modifications:

Use the same default maxFrameLength value (10 MB) for client and server

Result:

Fixes line#118
@trustin trustin self-assigned this Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trustin trustin

Labels
defect
Projects
None yet
Milestone
0.11.0.Final
Development

No branches or pull requests
2 participants
@trustin @anuraaga