-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gRPC server connection option: MAX_CONNECTION_AGE #1636
Comments
Sounds like a good idea. I believe we could add more options related with server-side connection life cycle for all requests, not just gRPC. FYI, there is currently only one knob for connection life cycle: |
Adding my 2 cents here: We're running code in a restricted environment that kills long-lived TCP connections after a while to prevent resource leakage. The result is that the clients will try to use a TCP connection that was killed by some layer 4 infrastructure, and will fail. Without this configuration, the client needs to implement retry logic: if this configuration were exposed, we could instead make a single server-side change to fix this. |
I didn’t know we have this issue. |
Ah, I was looking in the wrong section of the docs. I'll have to give it a try and see if it helps |
Feel free to comment on this issue if it is not working as expected. 😀 |
grpc-java provides an option
MAX_CONNECTION_AGE
to allow gRPC server to manage a duration of TCP connection. When a connection exceeds theMAX_CONNECTION_AGE
, the server sends GOAWAY and terminates it.https://github.com/grpc/proposal/blob/master/A9-server-side-conn-mgt.md
Could armeria-grpc supoort this option?
The text was updated successfully, but these errors were encountered: