Provide a way to close a connection when exceeding the maximum age on server-side #2747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikhoon
changed the title
ikhoon
commented
May 27, 2020
core/src/main/java/com/linecorp/armeria/server/ServerBuilder.java
Outdated
Show resolved
Hide resolved
trustin
reviewed
May 27, 2020
core/src/main/java/com/linecorp/armeria/server/Http2ServerConnectionHandler.java
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/HttpServerPipelineConfigurator.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/ServerBuilder.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/linecorp/armeria/server/ServerMaxConnectionAgeTest.java
Show resolved
Hide resolved
core/src/test/java/com/linecorp/armeria/server/ServerMaxConnectionAgeTest.java
Outdated
Show resolved
Hide resolved
Motivation:
Sometimes users might want to disconnect an active connection after a certain period of time.
This is useful when balance loads with a L4 load balancer which not understand HTTP2 connection.
By closing connections periodically, new connections are able to spread to other servers.
Modifications:
- Add `defaultServerMaxConnectionAgeMillis` flag. This option is disabled by default.
- Add `maxConnectionAge{Millis} to `ServerBuilder`.
- Record `CONNECTION_START_TIME_NANO` when a channel is initialized.
- Disconnect a connection after exceeding maxConnectionAge by sending:
- "Connection: close" for HTTP/1
- GOAWAY frame for HTTP/2
- Fix a bug where `channel.close()` throws NullPointerException when idle timeout is set to 0
Result:
- You can now send `GOAWAY` frame with HTTP/2 and `Connection: close`
with HTTP/1 for an old connection on server-side.
ikhoon
force-pushed
the
server-max-connection-age
branch
from
17a68a0
to
ab7e489
Compare
trustin
reviewed
Jun 2, 2020
core/src/main/java/com/linecorp/armeria/server/HttpServerHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/HttpServerHandler.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/ServerHttp1ObjectEncoder.java
Outdated
Show resolved
Hide resolved
core/src/test/java/com/linecorp/armeria/server/ServerMaxConnectionAgeTest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #2747 +/- ##
============================================
+ Coverage 72.70% 72.80% +0.09%
- Complexity 11756 11867 +111
============================================
Files 1032 1042 +10
Lines 45875 46134 +259
Branches 5720 5757 +37
============================================
+ Hits 33355 33588 +233
+ Misses 9599 9596 -3
- Partials 2921 2950 +29 Continue to review full report at Codecov.
|
trustin
reviewed
Jun 4, 2020
core/src/main/java/com/linecorp/armeria/internal/common/KeepAliveHandler.java
Outdated
Show resolved
Hide resolved
trustin
reviewed
Jun 4, 2020
core/src/test/java/com/linecorp/armeria/server/ServerMaxConnectionAgeTest.java
Outdated
Show resolved
Hide resolved
trustin
approved these changes
Jun 4, 2020
minwoox
approved these changes
Jun 4, 2020
core/src/main/java/com/linecorp/armeria/server/ServerBuilder.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/linecorp/armeria/server/ServerBuilder.java
Outdated
Show resolved
Hide resolved
fmguerreiro
pushed a commit
to fmguerreiro/armeria
that referenced
this pull request
Sep 19, 2020
… server-side (line#2747) Motivation: Sometimes users might want to disconnect an active connection after a certain period of time. This is useful when balance loads with an L4 load balancer which not understand HTTP2 connection. By closing connections periodically, new connections are able to spread to other servers. Modifications: - Add `defaultServerMaxConnectionAgeMillis` flag. This option is disabled by default. - Add `maxConnectionAge{Millis} to `ServerBuilder`. - Record `CONNECTION_START_TIME_NANO` when a channel is initialized. - Disconnect a connection after exceeding `maxConnectionAge` by sending: - "Connection: close" for HTTP/1 - GOAWAY frame for HTTP/2 - Fix a bug where `channel.close()` throws NullPointerException when idle timeout is set to 0 Result: - You can now disconnect an old connection.
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Jan 7, 2021
…for client Motivation: A long connection can cause load imbalance between servers if clients does not use client-side balance. The clients will use L4 loadbalancer which keeps a connection to a server. The traffic could be rebalanced by closing connections periodically or after N requests. A max connection age for server-side was added by line#2747. However max connection age for client and max number of requeets for server and client have not impletemented yet. Related: line#203 line#2741 line#2747 Modifications: - Add `maxNumRequests` to `ServerBuilder`, `ClientFactoryBuilder` and `Flags` - Send `GOAWAY` or `Connection: close` by server-side - Remove from channel pool and close a connection or send `GOAWAY` by client-side - Add `maxConnnectionAge{Millis}` to `ClientFactoryBuilder` and `Flags` - Keep track of requests count by KeepAliveHandler to determine a connection is needed to close - Remove some fields, derived from ClientFatory, in `HttpChannelPool` and pass `ClientFactory` to `HttpSessionHandler` for reducing object size and simplicity. - Add `MaxConnectionAgeExceededTask` to close an expired connection. Result: - You can now set a maximum allowed number of requests for a connection. ```java // For server Server.builder() // A connection will be closed after serving 10000 requests. .maxNumRequests(10000); // For client ClientFactory.builder() // A connection will be closed after fully receving 2000th requests. .maxNumRequests(2000) ``` - You can now set a maximum allowed connection age for a connection on client-side. ```java // A connection will be closed in 10 seconds after the connection is established. ClientFactory.builder() .maxConnnectionAgeMillis(10000) ``` - Fixes line#203
ikhoon
added a commit
to ikhoon/armeria
that referenced
this pull request
Jan 7, 2021
…for client Motivation: A long connection can cause load imbalance between servers if clients do not use client-side balance. The clients which use L4 load balancers keep a connection to a server. The traffic could be rebalanced by closing connections periodically or after N requests. A max connection age for server-side was added by line#2747. However max connection age for client and max number of requests for server and client have not implemented yet. Related: line#203 line#2741 line#2747 Modifications: - Add `maxNumRequests` to `ServerBuilder`, `ClientFactoryBuilder` and `Flags` - Send `GOAWAY` or `Connection: close` by server-side - Remove from channel pool and close a connection or send `GOAWAY` by client-side - Add `maxConnnectionAge{Millis}` to `ClientFactoryBuilder` and `Flags` - Keep track of requests count by KeepAliveHandler to determine a connection is needed to close - Remove some fields, derived from ClientFatory, in `HttpChannelPool` and pass `ClientFactory` to `HttpSessionHandler` for reducing object size and simplicity. - Add `MaxConnectionAgeExceededTask` to close an expired connection. Result: - You can now set a maximum allowed number of requests for a connection. ```java // For server Server.builder() // A connection will be closed after serving 10000 requests. .maxNumRequests(10000); // For client ClientFactory.builder() // A connection will be closed after fully receiving 2000th requests. .maxNumRequests(2000) ``` - You can now set a maximum allowed connection age for a connection on client-side. ```java // A connection will be closed in 10 seconds after the connection is established. ClientFactory.builder() .maxConnnectionAgeMillis(10000) ``` - Fixes line#203
trustin
pushed a commit
that referenced
this pull request
Jan 27, 2021
…for client (#3267) Motivation: A long connection can cause load imbalance between servers if clients do not use client-side balance. Because L4 load balancers keep a client connection to a server. The traffic could be rebalanced by closing connections periodically or after N requests. A max connection age for server-side was added by #2747. However max connection age for client and max number of requests for server and client have not implemented yet. Related: #203 #2741 #2747 Modifications: - Add `maxNumRequestsPerConnection` to `ServerBuilder`, `ClientFactoryBuilder` and `Flags` - Send `GOAWAY` or `Connection: close` by server-side - Remove from channel pool and close a connection or send `GOAWAY` by client-side - Add `maxConnnectionAge{Millis}` to `ClientFactoryBuilder` and `Flags` - Keep track of requests count by KeepAliveHandler to determine a connection is needed to close - Remove some fields, derived from ClientFatory, in `HttpChannelPool` and pass `ClientFactory` to `HttpSessionHandler` for reducing object size and simplicity. - Add `MaxConnectionAgeExceededTask` to close an expired connection. Result: - You can now set a maximum allowed number of requests for a connection. ```java // For server Server.builder() // A connection will be closed after serving 10000 requests. .maxNumRequestsPerConnection(10000); // For client ClientFactory.builder() // A connection will be closed after fully receiving the response of 2000th requests. .maxNumRequestsPerConnection(2000); ``` - You can now set a maximum allowed connection age for a connection on client-side. ```java // A connection will be closed in 10 seconds after the connection is established. ClientFactory.builder() .maxConnnectionAgeMillis(10000); ``` - Fixes #203 Co-authored-by: julie-kim <julie.kim@linecorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes users might want to disconnect an active connection after a certain period of time.
This is useful when balance loads with an L4 load balancer which not understand HTTP2 connection.
By closing connections periodically, new connections are able to spread to other servers.
Modifications:
defaultServerMaxConnectionAgeMillisflag. This option is disabled by default.maxConnectionAge{Millis} toServerBuilder`.CONNECTION_START_TIME_NANOwhen a channel is initialized.maxConnectionAgeby sending:channel.close()throws NullPointerException when idle timeout is set to 0Result: