Upgrade to Netty 4.1.0.CR1 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
trustin
commented
Jan 29, 2016
trustin
commented
- Remove the DnsNameResolverGroup workaround
- Fix the H1C-to-H2C upgrade regression by using the fix at:
- Fix missing trailing data on HTTP client upgrade netty/netty#4785
- Update Http1ClientCodec forked from upstream
- Add Http1ClientUpgradeHandler forked from upstream
|
|
||
| private final SourceCodec sourceCodec; | ||
| private final UpgradeCodec upgradeCodec; | ||
| private boolean upgradeRequested; |
There was a problem hiding this comment.
Is it fine for this flag not to be volatile ?
There was a problem hiding this comment.
Yes. Netty handler methods are invoked from the same thread.
There was a problem hiding this comment.
👍
On Feb 2, 2016 7:54 PM, "Trustin Lee" notifications@github.com wrote:
In
src/main/java/com/linecorp/armeria/common/http/Http1ClientUpgradeHandler.java
#102 (comment):
/**\* Removes or disables the encoder of this codec so that the {@link UpgradeCodec} can send an initial greeting\* (if any).*/void prepareUpgradeFrom(ChannelHandlerContext ctx);
/**\* Removes this codec (i.e. all associated handlers) from the pipeline.*/void upgradeFrom(ChannelHandlerContext ctx);- }
- private final SourceCodec sourceCodec;
- private final UpgradeCodec upgradeCodec;
- private boolean upgradeRequested;
Yes. Netty handler methods are invoked from the same thread.
—
Reply to this email directly or view it on GitHub
https://github.com/line/armeria/pull/102/files#r51552856.
- Remove the DnsNameResolverGroup workaround - Fix the H1C-to-H2C upgrade regression by using the fix at: - netty/netty#4785 - Update Http1ClientCodec forked from upstream - Add Http1ClientUpgradeHandler forked from upstream
trustin
force-pushed
the
netty_4.1.0.CR1
branch
from
b2aff94
to
3fc7ae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.