Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that 2nd "!" of these should not be. These javadoc says, "log-if-not-isExpected", but the code is "nothing-if-not-isExpected".
[Background]
In some service, too many "Connection reset" exceptions like below are logged after version up the armeria (0.8.0.Final -> 0.9.0.Final).
It may be the effect of #105 (released in 0.9.0.Final)