Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log skip condition #119

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Fix log skip condition #119

merged 1 commit into from
Mar 4, 2016

Conversation

yohsuke
Copy link
Contributor

@yohsuke yohsuke commented Mar 3, 2016

I think that 2nd "!" of these should not be. These javadoc says, "log-if-not-isExpected", but the code is "nothing-if-not-isExpected".

[Background]

In some service, too many "Connection reset" exceptions like below are logged after version up the armeria (0.8.0.Final -> 0.9.0.Final).

It may be the effect of #105 (released in 0.9.0.Final)

2016-03-03 18:10:36.424 WARN  nioEventLoopGroup-7-6 com.linecorp.armeria.server.HttpServerHandler:53 - [id: 0x648cec6b, L:/XX.XX.XX.XX:20012 - R:/YY.YY.YY.YY:30664] Unexpected exception:
java.io.IOException: Connection reset by peer
        at sun.nio.ch.FileDispatcherImpl.read0(Native Method) ~[na:1.8.0_66]
        at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39) ~[na:1.8.0_66]
        at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223) ~[na:1.8.0_66]
        at sun.nio.ch.IOUtil.read(IOUtil.java:192) ~[na:1.8.0_66]
        at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:380) ~[na:1.8.0_66]
        at io.netty.buffer.PooledUnsafeDirectByteBuf.setBytes(PooledUnsafeDirectByteBuf.java:288) ~[beacon-lineapi.jar:na]
        at io.netty.buffer.AbstractByteBuf.writeBytes(AbstractByteBuf.java:1055) ~[beacon-lineapi.jar:na]
        at io.netty.channel.socket.nio.NioSocketChannel.doReadBytes(NioSocketChannel.java:245) ~[beacon-lineapi.jar:na]
        at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:112) ~[beacon-lineapi.jar:na]
        at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:510) [beacon-lineapi.jar:na]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:467) [beacon-lineapi.jar:na]
        at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:381) [beacon-lineapi.jar:na]
        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:353) [beacon-lineapi.jar:na]
        at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:742) [beacon-lineapi.jar:na]
        at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137) [beacon-lineapi.jar:na]
        at java.lang.Thread.run(Thread.java:745) [na:1.8.0_66]

@trustin trustin self-assigned this Mar 4, 2016
@trustin trustin added the defect label Mar 4, 2016
@trustin trustin added this to the 0.11.0.Final milestone Mar 4, 2016
trustin added a commit that referenced this pull request Mar 4, 2016
@trustin trustin merged commit 9e7a801 into line:master Mar 4, 2016
@trustin
Copy link
Member

trustin commented Mar 4, 2016

@yohsuke Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants