Disconnect before HTTP/2 stream ID overflows #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related issue: line#69 Motivation: When we keep an HTTP/2 connection long enough to handle more than 1G requests, the stream ID will exceed Integer.MAX_VALUE. It's probably a good idea for an Armeria client to close the connection before hitting the limit. Modifications: - Add HttpSession that provides the operations related with session management - Replace the static methods in HttpSessionHandler with get() which returns HttpSession that provides everything needed - Do not return the channel to the pool if the number of the sent requests exceeds a threshold - Close the channel if the number of the sent requests exceeds a threshold and there are no requests that await responses Result: - Fixes line#69
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #69
Motivation:
When we keep an HTTP/2 connection long enough to handle more than 1G
requests, the stream ID will exceed Integer.MAX_VALUE. It's probably a
good idea for an Armeria client to close the connection before hitting
the limit.
Modifications:
management
returns HttpSession that provides everything needed
requests exceeds a threshold
threshold and there are no requests that await responses
Result: