Fix 'exceptionCaught/inbound message reached at the tail of the pipeline' warnings #131
+116
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trustin
force-pushed
the
no_reached_at_the_tail
branch
from
2188352
to
bea410d
Compare
…ine' warnings
Motivation:
Because HttpSessionHandler is added only after protocol negotiation is
complete, a message or an exception triggered before then has a chance
of hitting the tail of the pipeline. As a result, a user can see the
following messages from Netty:
> An exceptionCaught() event was fired, and it reached at the tail of
> the pipeline.
and:
> Discarded inbound message {} that reached at the tail of the pipeline.
Modifications:
- Refactor HttpSessionChannelFactory and HttpSessionHandler so that
HttpSessionHandler is always available as soon as the connection
attempt is successful
- Move protocol negotiation signal processing to HttpSessionHandler so
that HttpSessionChannelFactory focuses on the connection attempt
Result:
- No more warning messages which confuses a user
- Slightly cleaner code
trustin
force-pushed
the
no_reached_at_the_tail
branch
from
bea410d
to
d128037
Compare
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Because HttpSessionHandler is added only after protocol negotiation is
complete, a message or an exception triggered before then has a chance
of hitting the tail of the pipeline. As a result, a user can see the
following messages from Netty:
and:
Modifications:
HttpSessionHandler is always available as soon as the connection
attempt is successful
that HttpSessionChannelFactory focuses on the connection attempt
Result: