Add Content-Length header for every responses #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blmarket
force-pushed
the
feature-content_length
branch
2 times, most recently
from
bf84958
to
c0efc88
Compare
Motivation: Currently armeria does not set `Content-Length` header for last request of connection, Using 5th rule of [RFC 4.4](http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4) to indicate transfer-length of the body. But, [RFC 14.13](http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.13) mentions that application should use `Content-Length` to indicate transfer-length, even though 4.4 seems to allow this. also, 14.13 prohibits to send content-length when response should not have entity body, which armeria did not followed. Also some clients depend on `Content-Length` only, which works incorrectly if no header is provided. Modifications: - Set `Content-Length` header if response have entity body, regardless of connection status. Result: More standard-compliant, and it works better with other clients.
|
This PR is duplicated with #141, will close when it's merged. |
blmarket
force-pushed
the
feature-content_length
branch
from
6f42074
to
a99a7ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently armeria does not set
Content-Lengthheader for last requestof connection, Using 5th rule of RFC 4.4 to indicate transfer-length of the body.
But, RFC 14.13 mentions that application should use
Content-Lengthto indicatetransfer-length, even though 4.4 seems to allow this. also, 14.13
prohibits to send content-length when response should not have entity
body, which armeria did not followed.
Also some clients depend on
Content-Lengthonly, which worksincorrectly if no header is provided.
Modifications:
Content-Lengthheader if response have entity body, regardlessof connection status.
Result:
More standard-compliant, and it works better with other clients.