Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release note for 1.1.0 #3070

Merged
merged 6 commits into from
Sep 22, 2020
Merged

Add release note for 1.1.0 #3070

merged 6 commits into from
Sep 22, 2020

Conversation

minwoox
Copy link
Member

@minwoox minwoox commented Sep 18, 2020

No description provided.

@minwoox minwoox added this to the 1.1.0 milestone Sep 18, 2020
@minwoox
Copy link
Member Author

minwoox commented Sep 18, 2020 •
edited
Loading

This does not include #3057 yet.

@codecov
Copy link

codecov bot commented Sep 18, 2020 •
edited
Loading

Codecov Report

Merging #3070 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3070      +/-   ##
============================================
+ Coverage     73.37%   73.40%   +0.03%     
- Complexity    12297    12306       +9     
============================================
  Files          1066     1066              
  Lines         47616    47623       +7     
  Branches       6007     6009       +2     
============================================
+ Hits          34937    34960      +23     
+ Misses         9628     9613      -15     
+ Partials       3051     3050       -1
Impacted Files Coverage Δ Complexity Δ
...eria/internal/spring/ArmeriaConfigurationUtil.java 63.82% <66.66%> (+0.52%) 23.00 <0.00> (+1.00)
...com/linecorp/armeria/server/saml/SamlEndpoint.java 62.50% <0.00%> (-2.50%) 10.00% <0.00%> (-1.00%)
...necorp/armeria/client/HeapBasedEventLoopState.java 92.78% <0.00%> (-1.04%) 31.00% <0.00%> (-1.00%)
.../linecorp/armeria/client/Http1ResponseDecoder.java 66.24% <0.00%> (-0.64%) 43.00% <0.00%> (-1.00%)
...a/common/grpc/protocol/ArmeriaMessageDeframer.java 74.42% <0.00%> (-0.46%) 53.00% <0.00%> (-1.00%)
...corp/armeria/common/logging/DefaultRequestLog.java 76.50% <0.00%> (-0.25%) 229.00% <0.00%> (-1.00%)
...om/linecorp/armeria/client/HttpSessionHandler.java 71.59% <0.00%> (+0.59%) 49.00% <0.00%> (+1.00%)
...ria/internal/common/logging/LoggingDecorators.java 90.47% <0.00%> (+1.00%) 14.00% <0.00%> (+4.00%)
...inecorp/armeria/server/grpc/ArmeriaServerCall.java 85.53% <0.00%> (+1.27%) 80.00% <0.00%> (ø%)
...rp/armeria/common/stream/DefaultStreamMessage.java 86.73% <0.00%> (+2.04%) 67.00% <0.00%> (+1.00%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba2601e...cbb78d6. Read the comment docs.

@trustin
Copy link
Member

trustin commented Sep 20, 2020

How about including #3024?

trustin
trustin reviewed Sep 20, 2020
View reviewed changes
site/src/pages/release-notes/1.1.0.mdx Outdated Show resolved Hide resolved
site/src/pages/release-notes/1.1.0.mdx Outdated Show resolved Hide resolved
site/src/pages/release-notes/1.1.0.mdx Outdated Show resolved Hide resolved
site/src/pages/release-notes/1.1.0.mdx Outdated Show resolved Hide resolved
site/src/pages/release-notes/1.1.0.mdx Outdated Show resolved Hide resolved
site/src/pages/release-notes/1.1.0.mdx Outdated
- Armeria Spring boot autoconfigure collects metrics correctly if <type://ArmeriaSettings#enableMetrics>
is `true`. #3048
- You now see the proper exception from WebFlux `WebClient` when <type://CircuitBreakerClient> is applied. #3064
- Armeria client rejects `PUSH_PROMISE` frame correctly because it doesn't support it yet. #3045
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • rejects -> now rejects
  • a PUSH_PROMISE frame (missing a)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PUSH_PROMISE frame is not rejected. SETTINGS_ENABLE_PUSH of the initial settings is set to 0.

Armeria client tells the server that it doesn't expect PUSH_PROMISE. ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PUSH_PROMISE frame is not rejected.

If a non Armeria server ignores SETTINGS_ENABLE_PUSH and sends PUSH_PROMISE, we don't reject the frame? then I think we should fix the code. 😄

ikhoon
ikhoon reviewed Sep 20, 2020
View reviewed changes
site/src/pages/release-notes/1.1.0.mdx Outdated Show resolved Hide resolved
site/src/pages/release-notes/1.1.0.mdx Outdated Show resolved Hide resolved
site/src/pages/release-notes/1.1.0.mdx Outdated
- Armeria Spring boot autoconfigure collects metrics correctly if <type://ArmeriaSettings#enableMetrics>
is `true`. #3048
- You now see the proper exception from WebFlux `WebClient` when <type://CircuitBreakerClient> is applied. #3064
- Armeria client rejects `PUSH_PROMISE` frame correctly because it doesn't support it yet. #3045
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PUSH_PROMISE frame is not rejected. SETTINGS_ENABLE_PUSH of the initial settings is set to 0.

Armeria client tells the server that it doesn't expect PUSH_PROMISE. ?

@minwoox
Copy link
Member Author

minwoox commented Sep 21, 2020

@trustin and @ikhoon All fixed. 😉

ikhoon
ikhoon approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@ikhoon ikhoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @minwoox

@minwoox minwoox merged commit cdb176d into line:master Sep 22, 2020
@minwoox minwoox deleted the release_note_1.1.0 branch September 22, 2020 02:33
@minwoox
Copy link
Member Author

minwoox commented Sep 22, 2020

Thanks for reviewing. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trustin trustin trustin left review comments

@ikhoon ikhoon ikhoon approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@minwoox @trustin @ikhoon