Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TraceAbleRequestContextStorage for ease of detect context leaks #4232

Merged
merged 46 commits into from
Sep 5, 2022
Merged

Add TraceAbleRequestContextStorage for ease of detect context leaks #4232

merged 46 commits into from
Sep 5, 2022

Commits on Apr 26, 2022

  1. Add TraceAbleRequestContextStorage for ease of detect context leak

    @klurpicolo
    klurpicolo committed Apr 26, 2022
    Configuration menu
    Copy the full SHA
    1d64827 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Update classname

    @klurpicolo
    klurpicolo committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    c79b852 View commit details
    Browse the repository at this point in the history

  2. Add Sampler to constructor of LeakTracingRequestContextStorage

    @klurpicolo
    klurpicolo committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    443e740 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2022

  1. Add benchmark on LeakTracingRequestContextStorage 

    Benchmark result:
```
Benchmark                                                              Mode  Cnt          Score         Error  Units
LeakTracingRequestContextStorageBenchmark.baseline_threadLocal        thrpt    5  138905863.970 ± 1832287.597  ops/s
LeakTracingRequestContextStorageBenchmark.leakTracing_always_sample   thrpt    5    1347325.018 ±    7907.388  ops/s
LeakTracingRequestContextStorageBenchmark.leakTracing_never_sample    thrpt    5   10762418.543 ±   43741.747  ops/s
LeakTracingRequestContextStorageBenchmark.leakTracing_random_1        thrpt    5    9351586.968 ±    8154.426  ops/s
LeakTracingRequestContextStorageBenchmark.leakTracing_random_10       thrpt    5    5915767.799 ±   15699.257  ops/s
LeakTracingRequestContextStorageBenchmark.leakTracing_rateLimited_1   thrpt    5    9677373.483 ±   46283.720  ops/s
LeakTracingRequestContextStorageBenchmark.leakTracing_rateLimited_10  thrpt    5   10027495.272 ±  129500.874  ops/s
```
    @klurpicolo
    klurpicolo committed May 1, 2022
    Configuration menu
    Copy the full SHA
    c431103 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2022

  1. Add finally when pop

    @klurpicolo
    klurpicolo committed May 5, 2022
    Configuration menu
    Copy the full SHA
    06c728e View commit details
    Browse the repository at this point in the history

  2. Change generic of Sampler

    @klurpicolo
    klurpicolo committed May 5, 2022
    Configuration menu
    Copy the full SHA
    0f5e5e5 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Merge branch 'master' into context-leak-debug

    @ikhoon
    ikhoon authored May 13, 2022
    Configuration menu
    Copy the full SHA
    bcf92df View commit details
    Browse the repository at this point in the history

  2. Add UnstableApi and check null input

    @klurpicolo
    klurpicolo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    82bb1a8 View commit details
    Browse the repository at this point in the history

  3. Refactor DeferredClose

    @klurpicolo
    klurpicolo committed May 13, 2022
    Configuration menu
    Copy the full SHA
    a7fd563 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2022

  1. Add current stacktrace to exception

    @klurpicolo
    klurpicolo committed May 14, 2022
    Configuration menu
    Copy the full SHA
    ea2e675 View commit details
    Browse the repository at this point in the history

  2. Use await instead of CountDownLatch in some tests

    @klurpicolo
    klurpicolo committed May 14, 2022
    Configuration menu
    Copy the full SHA
    cb8dcf4 View commit details
    Browse the repository at this point in the history

  3. Fix lint

    @klurpicolo
    klurpicolo committed May 14, 2022
    Configuration menu
    Copy the full SHA
    50d4127 View commit details
    Browse the repository at this point in the history

  4. Fix test

    @klurpicolo
    klurpicolo committed May 14, 2022
    Configuration menu
    Copy the full SHA
    818c166 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Provide a flag for enable requestContextLeakDetection

    @klurpicolo
    klurpicolo committed May 24, 2022
    Configuration menu
    Copy the full SHA
    5207a4c View commit details
    Browse the repository at this point in the history

  2. Move LeakDetectionConfiguration package outside of internal

    @klurpicolo
    klurpicolo committed May 24, 2022
    Configuration menu
    Copy the full SHA
    d24e0a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Replace LeakDetectionConfiguration with Sampler<? super RequestContext>

    @klurpicolo
    klurpicolo committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    61e767d View commit details
    Browse the repository at this point in the history

  2. Change flag name from requestContextLeakDetection to requestContextLe… 

    …akDetectionSampler
    @klurpicolo
    klurpicolo committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    449f051 View commit details
    Browse the repository at this point in the history

  3. Refactor RequestContextUtil

    @klurpicolo
    klurpicolo committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4dabd01 View commit details
    Browse the repository at this point in the history

  4. Correct Java doc grammar

    @klurpicolo
    klurpicolo committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    8909ace View commit details
    Browse the repository at this point in the history

  5. Add newline to EOF

    @klurpicolo
    klurpicolo committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    fdd8490 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Correct comment and add UnstableApi

    @klurpicolo
    klurpicolo committed Jun 2, 2022
    Configuration menu
    Copy the full SHA
    5562cfe View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Update generic of Sampler

    @klurpicolo
    klurpicolo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    f124fc8 View commit details
    Browse the repository at this point in the history

  2. Move LeakTracingRequestContextStorage to internal.common

    @klurpicolo
    klurpicolo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    a71a725 View commit details
    Browse the repository at this point in the history

  3. Correct spelling

    @klurpicolo
    klurpicolo committed Jun 3, 2022
    Configuration menu
    Copy the full SHA
    c4a534f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Modifying Samplers.of(String) to accept true and false

    @klurpicolo
    klurpicolo committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    3b00c2a View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2022

  1. Add illegallyPushServiceRequestContext test

    @klurpicolo
    klurpicolo committed Jun 18, 2022
    Configuration menu
    Copy the full SHA
    af31a6e View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Refactor LeakTracingRequestContextStorage

    @klurpicolo
    klurpicolo committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    ab4de84 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. Merge branch 'master' into context-leak-debug 

    # Conflicts:
#	core/src/main/java/com/linecorp/armeria/internal/common/RequestContextUtil.java
    @klurpicolo
    klurpicolo committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9f681d4 View commit details
    Browse the repository at this point in the history

  2. Apply unwrapAll()

    @klurpicolo
    klurpicolo committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    a72a9ca View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Update core/src/main/java/com/linecorp/armeria/internal/common/LeakTr… 

    …acingRequestContextStorage.java

Co-authored-by: minux <songmw725@gmail.com>
    @ikhoon @minwoox
    ikhoon and minwoox authored Aug 16, 2022
    Configuration menu
    Copy the full SHA
    d43b052 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Use unwrap for root checking

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4f8a8f2 View commit details
    Browse the repository at this point in the history

  2. Override unwrap method

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    6cbcfab View commit details
    Browse the repository at this point in the history

  3. Add space on comment

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    89ddc46 View commit details
    Browse the repository at this point in the history

  4. Correct happen-before relationship

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    6b4b9f9 View commit details
    Browse the repository at this point in the history

  5. Add check latch to wait for another thread

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    083d560 View commit details
    Browse the repository at this point in the history

  6. Ensure multiThreadContextLeak executor2 summit

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    4fb9575 View commit details
    Browse the repository at this point in the history

  7. Use StackTraceElement

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    7b3f3d1 View commit details
    Browse the repository at this point in the history

  8. Fix case root is null

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    9d929bf View commit details
    Browse the repository at this point in the history

  9. Dedup toString

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    90e6e78 View commit details
    Browse the repository at this point in the history

  10. Use gradle task to copy test from core

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    a0540c8 View commit details
    Browse the repository at this point in the history

  11. Fix lint

    @klurpicolo
    klurpicolo committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    9156898 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Refactor equalUnwrapAllNullable

    @klurpicolo
    klurpicolo committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    50384a2 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2022

  1. Remove thread name from stacktrace

    @klurpicolo
    klurpicolo committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    0fe21fd View commit details
    Browse the repository at this point in the history

  2. Refactor equalUnwrapAllNullable

    @klurpicolo
    klurpicolo committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    caba3d6 View commit details
    Browse the repository at this point in the history

  3. Add guard clause

    @klurpicolo
    klurpicolo committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    1302481 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2022

  1. Correct spelling and remove UnstableApi

    @klurpicolo
    klurpicolo committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    9e8e10e View commit details
    Browse the repository at this point in the history