-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation about FlagsProvider #4870
Conversation
Apply the review and rebase the branch
28838f9
to
2be0f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Left some minor comments, but looks good! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @tomatophobia! Please address @jrhee17's comments.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4870 +/- ##
============================================
+ Coverage 74.18% 74.21% +0.03%
- Complexity 19472 19485 +13
============================================
Files 1672 1672
Lines 71799 71799
Branches 9202 9202
============================================
+ Hits 53261 53283 +22
+ Misses 14199 14186 -13
+ Partials 4339 4330 -9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a small commit, but looks good to me! Thanks a lot for the additional documentation @tomatophobia 🙇 👍 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @tomatophobia! 🙇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am so glad that now we have documentation for the Flags provider. 😆
Thanks a lot, @tomatophobia! 🚀 🚀 🚀
Motivation:
Modifications:
FlagsProvider
.Result: