Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-5578] make ContentTooLargeException extend HttpStatusException #5624

Closed
wants to merge 1 commit into from

Conversation

ChangguHan
Copy link
Contributor

Motivation:

Make ContentTooLargeException extend HttpStatusException
Issue #5578

Modifications:

  • Make HttpStatusException not final class
  • Make ContentTooLargeException extend HttpStatusException

Result:

@ikhoon
Copy link
Contributor

ikhoon commented Apr 22, 2024

I realized that ContentTooLargeException can't simply extend HttpStatusException because HttpStatusException is in server package but ContentTooLargeException is in common.

I think my first idea was wrong, sorry. This issue should be considered in Armeria 2.0. Would you mind closing this PR and looking at other issues?

@ChangguHan
Copy link
Contributor Author

@ikhoon
No problem. Thank you 👍

@ChangguHan ChangguHan closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider making ContentTooLargeException extend HttpStatusException
2 participants