Handle HTTP/2 upgrade response from the stream 1 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,8 +61,10 @@ | |||
| import io.netty.handler.codec.http2.Http2ConnectionHandler; | |||
| import io.netty.handler.codec.http2.Http2FrameReader; | |||
| import io.netty.handler.codec.http2.Http2FrameWriter; | |||
| import io.netty.handler.codec.http2.Http2Headers.PseudoHeaderName; | |||
Motivation: Once an upgrade to HTTP/2 is finished in a cleartext connection, the server sends the response for the upgrade request to the client via the stream 1. Armeria client currently does not handle it explicitly, causing the response to reach at the end of the pipeline. This is not necessarily harmful, but it will pollute our DEBUG log level because Netty will log any messages that reach at the end of the pipeline. Modifications: - Make UpgradeHandler handle the upgrade response so that Netty does not complain - Change the next version to 0.6.1.Final Result: Less noisy log messages
trustin
force-pushed
the
handle_upgrade_response
branch
from
1c12d26
to
966b9b8
Compare
|
LGTM. 👍 |
blmarket
added a commit
that referenced
this pull request
Dec 9, 2015
Handle HTTP/2 upgrade response from the stream 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Once an upgrade to HTTP/2 is finished in a cleartext connection, the
server sends the response for the upgrade request to the client via the
stream 1. Armeria client currently does not handle it explicitly,
causing the response to reach at the end of the pipeline. This is not
necessarily harmful, but it will pollute our DEBUG log level because
Netty will log any messages that reach at the end of the pipeline.
Modifications:
complain
Result:
Less noisy log messages