Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a leak in an HTTP/2 connection #68

Merged
merged 1 commit into from
Dec 10, 2015
Merged

Conversation

trustin
Copy link
Member

@trustin trustin commented Dec 10, 2015

HttpSessionHandler.MultiplexWaitsHolder.poll() does not remove the polled request, causing a leak.

Also, replaced LinkedList with ArrayDeque for better performance and memory usage

@trustin trustin added the defect label Dec 10, 2015
@trustin trustin added this to the 0.6.2.Final milestone Dec 10, 2015
@trustin
Copy link
Member Author

trustin commented Dec 10, 2015

/cc @inch772

@inch772
Copy link
Contributor

inch772 commented Dec 10, 2015

thanks. T_T

HttpSessionHandler.MultiplexWaitsHolder.poll() does not remove the
polled request, causing a leak.

Also, replaced LinkedList with ArrayDeque for better performance and
memory usage
anuraaga added a commit that referenced this pull request Dec 10, 2015
Fix a leak in an HTTP/2 connection
@anuraaga anuraaga merged commit 876e86a into line:master Dec 10, 2015
@trustin trustin deleted the fix_leak branch December 10, 2015 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants