Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing HTTP request content conversion in TomcatService #71

Merged
merged 1 commit into from
Dec 18, 2015
Merged

Fix missing HTTP request content conversion in TomcatService #71

merged 1 commit into from
Dec 18, 2015

Conversation

trustin
Copy link
Member

@trustin trustin commented Dec 17, 2015

  • Original work by @delegacy
  • Improve HTTP request header conversion
  • Improve HTTP response header conversion
  • Add HTTP request content conversion

@trustin trustin added the defect label Dec 17, 2015
@trustin trustin added this to the 0.7.0.Final milestone Dec 17, 2015
@trustin
Copy link
Member Author

trustin commented Dec 17, 2015

@delegacy PTAL

@trustin trustin modified the milestones: 0.6.3.Final, 0.7.0.Final Dec 17, 2015
@trustin trustin force-pushed the fix_tomcat_post branch 2 times, most recently from 12832ae to 7d5f3c8 Compare December 17, 2015 10:32
delegacy
delegacy reviewed Dec 18, 2015
View reviewed changes
src/main/java/com/linecorp/armeria/server/http/tomcat/TomcatServiceInvocationHandler.java
return;
}

for (Iterator<Entry<CharSequence, CharSequence>> i = headers.iteratorCharSequence(); i.hasNext();) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDE complains about a missing whitespace after ;.

@delegacy
Copy link
Contributor

Confirmed that the defects has been fixed. 😄

@trustin
Fix missing HTTP request content conversion in TomcatService
6fdb993 
- Original work by @delegacy
- Improve HTTP request header conversion
- Improve HTTP response header conversion
- Add HTTP request content conversion
@delegacy
Copy link
Contributor

LGTM

delegacy added a commit that referenced this pull request Dec 18, 2015
@delegacy
Merge pull request #71 from trustin/fix_tomcat_post
5ec0259 
Fix missing HTTP request content conversion in TomcatService
@delegacy delegacy merged commit 5ec0259 into line:master Dec 18, 2015
@trustin trustin deleted the fix_tomcat_post branch December 18, 2015 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@delegacy delegacy

Labels
defect
Projects
None yet
Milestone
0.6.3.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@trustin @delegacy