Check all interfaces, including ancestor interfaces, when analyzing t… #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI is too lame :( |
| Set<Class<?>> interfaces = new HashSet<>(); | ||
| Collections.addAll(interfaces, clz.getInterfaces()); | ||
| if (clz.getSuperclass() != null) { | ||
| interfaces.addAll(getAllInterfaces(clz.getSuperclass())); |
There was a problem hiding this comment.
Craving for @tailrec in Java too...
The impl in commons-lang uses a loop: http://commons.apache.org/proper/commons-lang/javadocs/api-release/src-html/org/apache/commons/lang3/ClassUtils.html#line.433
There was a problem hiding this comment.
Yeah wasn't worrying too much about performance since this is all heavily reflective and only happens once, but guess it's not so hard to use the shared set. Anyways I realized I forgot about superinterfaces, so just went with the apache implementation.
anuraaga
force-pushed
the
work
branch
2 times, most recently
from
7767756
to
2128470
Compare
trustin
added a commit
that referenced
this pull request
Jan 28, 2016
Check all interfaces, including ancestor interfaces, when analyzing t…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…hrift service.
Currently, a thrift handler must directly inherit from the thrift service implementation to be processed by armeria properly. This can actually crop up often for spring users, where it's not uncommon to be dealing with automatically codegenned subclass proxies if using AOP.