Add integration tests for BraveTracingProvider #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocadaruma
reviewed
Feb 26, 2021
brave/src/it/java/com/linecorp/decaton/processor/runtime/BraveTracingTest.java
Outdated
Show resolved
Hide resolved
brave/src/it/java/com/linecorp/decaton/processor/runtime/BraveTracingTest.java
Show resolved
Hide resolved
brave/src/it/java/com/linecorp/decaton/processor/runtime/BraveTracingTest.java
Outdated
Show resolved
Hide resolved
brave/src/it/java/com/linecorp/decaton/processor/runtime/BraveTracingTest.java
Outdated
Show resolved
Hide resolved
| } | ||
| })) | ||
| .producerSupplier( | ||
| bootstrapServers -> kafkaTracing.producer(TestUtils.producer(bootstrapServers))) |
There was a problem hiding this comment.
Is that necessary to pass producerSupplier ?
.producerDecorator(kafkaTracing::producer)more natural?
There was a problem hiding this comment.
I thought there might be future tests where we wanted to supply a completely new producer (e.g. a mock/stub, different configuration parameters) rather than just wrap the existing one.
brave/src/it/java/com/linecorp/decaton/processor/runtime/BraveTracingTest.java
Show resolved
Hide resolved
ocadaruma
reviewed
Mar 2, 2021
testing/src/main/java/com/linecorp/decaton/testing/processor/ProcessorTestSuite.java
Outdated
Show resolved
Hide resolved
|
I think build failure is a known flaky test? |
|
Oh, it's not known but shouldn't be related to this PR's change... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have an integration test for tracing in general, but it's good to confirm that the specific integration with Brave also works