Include non-relocated modules when running shadedTest.
#181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: When a non-relocated module (Module A) is used by a relocated module (Module B), running `:B:shadedTest` results in a `NoClassDefError` because Module A is not included in Module B's `shadedJarTestImplementation` configuration. Modifications: - Included non-relocated modules (e.g., Module A) in the `shadedJarTestImplementation` configuration of relocated modules (e.g., Module B). - Raised an exception if a non-relocated module needs to be relocated. Result: - Running `shadedTest` for relocated modules now includes necessary non-relocated modules.
jrhee17
approved these changes
Jun 24, 2024
Comment on lines
+379
to
+380
| shadedJarTestImplementation.dependencies.add( | ||
| project.dependencies.project(path: dep.dependencyProject.path)) |
There was a problem hiding this comment.
Question) I haven't been able to look into this in detail. If the project.dependencies contains a dependency that should've been shaded, will this case be covered correctly?
There was a problem hiding this comment.
I believe so. An exception will be raised from here:
https://github.com/line/gradle-scripts/pull/181/files#diff-5c14d66c4edef5e74eac3b83b26ba720aafc5b5b008248dea72d951aa64170deR357-R360
There was a problem hiding this comment.
Checked that transient dependencies aren't taken care of for some reason previously as well which made me confused.
I guess functionally there is no difference then.
|
Approved by mistake 😅 |
ikhoon
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When a non-relocated module (Module A) is used by a relocated module (Module B), running
:B:shadedTestresults in aNoClassDefErrorbecause Module A is not included in Module B'sshadedJarTestImplementationconfiguration.Modifications:
shadedJarTestImplementationconfiguration of relocated modules (e.g., Module B).Result:
shadedTestfor relocated modules now includes necessary non-relocated modules.