Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move file-type to optional dependency #745

Merged
merged 4 commits into from
Mar 11, 2024
Merged

Move file-type to optional dependency #745

merged 4 commits into from
Mar 11, 2024

Conversation

Yang-33
Copy link
Contributor

@Yang-33 Yang-33 commented Mar 10, 2024

because file-type is only used in deprecated client.

line-bot-sdk-nodejs/lib/http-axios.ts

Line 9 in 1bccab7

import * as fileType from "file-type";

@Yang-33 Yang-33 marked this pull request as ready for review March 10, 2024 08:10
tokuhirom
tokuhirom approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@tokuhirom tokuhirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yang-33 Yang-33 merged commit 02ec49f into line:master Mar 11, 2024
3 checks passed
@Yang-33 Yang-33 deleted the move-file-type-to-optional-dependency branch March 11, 2024 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tokuhirom tokuhirom tokuhirom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yang-33 @tokuhirom