Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile does not reflect changes to names to environment variables #68

Closed
witzatom opened this issue Mar 5, 2018 · 1 comment
Closed

Dockerfile does not reflect changes to names to environment variables #68

witzatom opened this issue Mar 5, 2018 · 1 comment
Assignees
@kfdm
Labels
bug

Comments

@witzatom
Copy link

witzatom commented Mar 5, 2018 •
edited
Loading

promgen/Dockerfile

Line 36 in 2248db6

ENV CONFIG_DIR=/etc/promgen

the variable should be PROMGEN_CONFIG_DIR not just CONFIG_DIR - this actually makes the current docker image at the master tag unusable

related changes in
1ef8f4d#diff-8183575a528efbf0c406468637fb6253
@kfdm
Copy link
Collaborator

kfdm commented Mar 5, 2018

You're correct. I had made those changes and expected them to be fixed in #56 but I should make a fix for just the individual value so that promgen:master works again. Sorry for the confusion :(

@kfdm kfdm self-assigned this Mar 5, 2018
@kfdm kfdm added the bug label Mar 5, 2018
kfdm added a commit to kfdm/promgen that referenced this issue Mar 6, 2018
@kfdm
Update PROMGEN_CONFIG_DIR in Dockerfile
cd17f2b 
Fixes line#68
@kfdm kfdm mentioned this issue Mar 6, 2018
Merged
@kfdm kfdm closed this as completed in #69 Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kfdm kfdm

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfdm @witzatom